Introduce 'kubectl argo rollouts create' command #295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #295 +/- ##
==========================================
- Coverage 83.81% 83.57% -0.24%
==========================================
Files 63 64 +1
Lines 5677 5845 +168
==========================================
+ Hits 4758 4885 +127
- Misses 671 692 +21
- Partials 248 268 +20
Continue to review full report at Codecov.
|
dthomson25
reviewed
Nov 14, 2019
Comment on lines
+101
to
+108
| func isJSON(fileBytes []byte) bool { | ||
| for _, b := range fileBytes { | ||
| if !unicode.IsSpace(rune(b)) { | ||
| return b == '{' | ||
| } | ||
| } | ||
| return false | ||
| } |
There was a problem hiding this comment.
I'm surprised there isn't an easier way of doing this with the libraries we imported so far.
There was a problem hiding this comment.
That being said, I only do a quick search to see if I find one, but otherwise, I think it's fine
dthomson25
reviewed
Nov 14, 2019
dthomson25
approved these changes
Nov 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
kubectl argo rollouts create -f file.yamlwith a-wwatch optionkubectl argo rollouts create analysisrunwith--from=templatenameor--from-file=template.yaml