Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cloudwatch metrics provider multiple dimensions #2932

Conversation

modesvops
Copy link
Contributor

@modesvops modesvops commented Aug 4, 2023

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional with a list of types and scopes found here, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I've signed my commits with DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My builds are green. Try syncing with master if they are not.
  • My organization is added to USERS.md.

Signed-off-by: Modestas Kulpinskas <modestas.kulpinskas@kevin.eu>
@modesvops modesvops force-pushed the cloudwatch-metrics-provider-multiple-dimensions branch from 3c8dd57 to 6677040 Compare August 4, 2023 05:31
@sonarcloud
Copy link

sonarcloud bot commented Aug 4, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
78.9% 78.9% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@codecov
Copy link

codecov bot commented Aug 4, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (d27d285) 81.75% compared to head (6677040) 81.75%.
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2932   +/-   ##
=======================================
  Coverage   81.75%   81.75%           
=======================================
  Files         133      133           
  Lines       20336    20338    +2     
=======================================
+ Hits        16625    16627    +2     
  Misses       2855     2855           
  Partials      856      856           
Files Changed Coverage Δ
metricproviders/cloudwatch/cloudwatch.go 73.45% <100.00%> (+0.47%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 4, 2023

Go Published Test Results

2 033 tests   2 033 ✔️  2m 39s ⏱️
   118 suites         0 💤
       1 files           0

Results for commit 6677040.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 4, 2023

E2E Tests Published Test Results

    4 files      4 suites   3h 37m 36s ⏱️
102 tests   89 ✔️   6 💤 7
416 runs  384 ✔️ 24 💤 8

For more details on these failures, see this check.

Results for commit 6677040.

@zachaller zachaller merged commit 9f4a5c9 into argoproj:master Aug 4, 2023
24 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants