Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a duration string instead of int to represent duration #286

Merged
merged 1 commit into from
Nov 13, 2019

Conversation

jessesuen
Copy link
Member

No description provided.

@jessesuen jessesuen requested a review from dthomson25 November 13, 2019 01:04
@codecov
Copy link

codecov bot commented Nov 13, 2019

Codecov Report

Merging #286 into master will decrease coverage by 0.09%.
The diff coverage is 76.92%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #286     +/-   ##
=========================================
- Coverage   83.86%   83.76%   -0.1%     
=========================================
  Files          63       63             
  Lines        5645     5661     +16     
=========================================
+ Hits         4734     4742      +8     
- Misses        666      671      +5     
- Partials      245      248      +3
Impacted Files Coverage Δ
experiments/experiment.go 93.3% <100%> (ø) ⬆️
...kubectl-argo-rollouts/cmd/list/list_experiments.go 93.54% <100%> (+0.1%) ⬆️
utils/analysis/factory.go 100% <100%> (ø) ⬆️
utils/experiment/experiment.go 92.23% <60%> (-1.77%) ⬇️
analysis/analysis.go 82.65% <69.56%> (-1.7%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ea957a1...c83e2b4. Read the comment docs.

Copy link
Member

@dthomson25 dthomson25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -3,7 +3,7 @@ kind: Experiment
metadata:
generateName: experiment-mann-whitney-u-
spec:
duration: 3600
duration: 3h
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it matters, but this was previous 1 hour not 3

@dthomson25 dthomson25 merged commit 0d51f44 into argoproj:master Nov 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants