fix(trafficrouting): apply stable selectors on canary service on rollout abort #2781 #2818
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
waiting for tests to run, want to see what fails, then will look into how to make a test to cover this. |
meeech
force-pushed
the
AR-2781-re-apply-old-canary-selector
branch
from
944b0e5
to
0b2cc3a
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #2818 +/- ##
==========================================
+ Coverage 81.66% 81.67% +0.01%
==========================================
Files 133 133
Lines 20192 20193 +1
==========================================
+ Hits 16490 16493 +3
+ Misses 2849 2847 -2
Partials 853 853
☔ View full report in Codecov by Sentry. |
meeech
force-pushed
the
AR-2781-re-apply-old-canary-selector
branch
2 times, most recently
from
45bb421
to
9726f7c
Compare
meeech
force-pushed
the
AR-2781-re-apply-old-canary-selector
branch
3 times, most recently
from
286bd1e
to
97e4731
Compare
meeech
force-pushed
the
AR-2781-re-apply-old-canary-selector
branch
from
a7db314
to
3aa470d
Compare
|
fwiw: all tests passed on my second run locally |
…ting is used fixes argoproj#2781 * remove redundant block of code Signed-off-by: mitchell amihod <4623+meeech@users.noreply.github.com>
Basically a copy/pasta of test that was checking for this when using traffic routing Signed-off-by: mitchell amihod <4623+meeech@users.noreply.github.com>
meeech
force-pushed
the
AR-2781-re-apply-old-canary-selector
branch
from
aefc7ee
to
9ffec5e
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
zachaller
approved these changes
Jul 11, 2023
agaudreault
added a commit
to agaudreault/argo-rollouts
that referenced
this pull request
Mar 22, 2024
… on rollout abort argoproj#2781 (argoproj#2818)" This reverts commit 3c5ac36. Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>
zachaller
added a commit
to zachaller/argo-rollouts
that referenced
this pull request
Mar 25, 2024
… on rollout abort argoproj#2781 (argoproj#2818)" This reverts commit 3c5ac36. Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>
zachaller
added a commit
to zachaller/argo-rollouts
that referenced
this pull request
Jun 14, 2024
… on rollout abort argoproj#2781 (argoproj#2818)" This reverts commit 3c5ac36. Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
"fix(controller): Updates such and such. Fixes #1234".