fix: istio dropping fields during removing of managed routes #2692
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: zachaller <zachaller@users.noreply.github.com>
|
Kudos, SonarCloud Quality Gate passed!
|
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #2692 +/- ##
=======================================
Coverage 81.62% 81.63%
=======================================
Files 133 133
Lines 20157 20163 +6
=======================================
+ Hits 16454 16460 +6
Misses 2849 2849
Partials 854 854
☔ View full report in Codecov by Sentry. |
Signed-off-by: zachaller <zachaller@users.noreply.github.com>
|
Hey! I'm keenly waiting for this feature, and just wanted to check in on the status? |
…stio-remove-routes-dropping-fields-1
Signed-off-by: zachaller <zachaller@users.noreply.github.com>
Signed-off-by: zachaller <zachaller@users.noreply.github.com>
|
SonarCloud Quality Gate failed.
|
zachaller
added a commit
that referenced
this pull request
May 5, 2023
* fix for dropping fields during removing routes Signed-off-by: zachaller <zachaller@users.noreply.github.com> * add comment and rename Signed-off-by: zachaller <zachaller@users.noreply.github.com> * add a light weight cast check Signed-off-by: zachaller <zachaller@users.noreply.github.com> * improve logic by adding type casting check Signed-off-by: zachaller <zachaller@users.noreply.github.com> * add docs Signed-off-by: zachaller <zachaller@users.noreply.github.com> --------- Signed-off-by: zachaller <zachaller@users.noreply.github.com>
zachaller
added a commit
that referenced
this pull request
May 5, 2023
* fix for dropping fields during removing routes Signed-off-by: zachaller <zachaller@users.noreply.github.com> * add comment and rename Signed-off-by: zachaller <zachaller@users.noreply.github.com> * add a light weight cast check Signed-off-by: zachaller <zachaller@users.noreply.github.com> * improve logic by adding type casting check Signed-off-by: zachaller <zachaller@users.noreply.github.com> * add docs Signed-off-by: zachaller <zachaller@users.noreply.github.com> --------- Signed-off-by: zachaller <zachaller@users.noreply.github.com>
zachaller
added a commit
that referenced
this pull request
May 5, 2023
* fix for dropping fields during removing routes Signed-off-by: zachaller <zachaller@users.noreply.github.com> * add comment and rename Signed-off-by: zachaller <zachaller@users.noreply.github.com> * add a light weight cast check Signed-off-by: zachaller <zachaller@users.noreply.github.com> * improve logic by adding type casting check Signed-off-by: zachaller <zachaller@users.noreply.github.com> * add docs Signed-off-by: zachaller <zachaller@users.noreply.github.com> --------- Signed-off-by: zachaller <zachaller@users.noreply.github.com>
zachaller
added
the
cherry-pick-completed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes istio support so that when managed route is called to cleanup, setMirror and setHeader routes it keeps extra fields on non managed routes.