feat: retain TLS configuration for canary ingresses in the nginx integration. Fixes #1134 #2679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #2679 +/- ##
=======================================
Coverage 81.68% 81.69%
=======================================
Files 133 133
Lines 20178 20184 +6
=======================================
+ Hits 16483 16489 +6
Misses 2843 2843
Partials 852 852
☔ View full report in Codecov by Sentry. |
Signed-off-by: Pavels Fjodorovs <pavels.fjodorovs@hotelplan.com>
Signed-off-by: Pavels Fjodorovs <pavels.fjodorovs@hotelplan.com>
Signed-off-by: Pavels Fjodorovs <me@pfyod.com>
|
LGTM |
|
Kudos, SonarCloud Quality Gate passed!
|
zachaller
approved these changes
May 30, 2023
|
when will this be released? |
|
may @zachaller knows? |
1 similar comment
|
may @zachaller knows? |
andyliuliming
pushed a commit
to andyliuliming/argo-rollouts
that referenced
this pull request
Jun 11, 2023
…gration. Fixes argoproj#1134 (argoproj#2679) * Retain TLS configuration for canary ingresses in the nginx integration Signed-off-by: Pavels Fjodorovs <pavels.fjodorovs@hotelplan.com> * Retain TLS configuration for canary ingresses in the nginx integration Signed-off-by: Pavels Fjodorovs <pavels.fjodorovs@hotelplan.com> * fixed tests after multiple nginx ingress merge Signed-off-by: Pavels Fjodorovs <me@pfyod.com> --------- Signed-off-by: Pavels Fjodorovs <pavels.fjodorovs@hotelplan.com> Signed-off-by: Pavels Fjodorovs <me@pfyod.com>
6 tasks
andyliuliming
pushed a commit
to andyliuliming/argo-rollouts
that referenced
this pull request
Jul 22, 2023
…gration. Fixes argoproj#1134 (argoproj#2679) * Retain TLS configuration for canary ingresses in the nginx integration Signed-off-by: Pavels Fjodorovs <pavels.fjodorovs@hotelplan.com> * Retain TLS configuration for canary ingresses in the nginx integration Signed-off-by: Pavels Fjodorovs <pavels.fjodorovs@hotelplan.com> * fixed tests after multiple nginx ingress merge Signed-off-by: Pavels Fjodorovs <me@pfyod.com> --------- Signed-off-by: Pavels Fjodorovs <pavels.fjodorovs@hotelplan.com> Signed-off-by: Pavels Fjodorovs <me@pfyod.com> Signed-off-by: Liming Liu <andyliuliming@outlook.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason (there's a comment but not explanation as to why), nginx integration does not copy TLS configuration from the stable ingress when creating canary ingresses (see issue #1134). This PR fixes that.
Checklist:
"fix(controller): Updates such and such. Fixes #1234".