Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Honor empty condition when evaluating prom results #265

Merged
merged 1 commit into from
Nov 6, 2019

Conversation

dthomson25
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Nov 6, 2019

Codecov Report

Merging #265 into master will increase coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #265      +/-   ##
==========================================
+ Coverage   83.66%   83.69%   +0.03%     
==========================================
  Files          59       59              
  Lines        5294     5306      +12     
==========================================
+ Hits         4429     4441      +12     
  Misses        632      632              
  Partials      233      233
Impacted Files Coverage Δ
metricproviders/prometheus/prometheus.go 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 353c60e...77f84a1. Read the comment docs.

@dthomson25 dthomson25 merged commit 08112e1 into master Nov 6, 2019
@dthomson25 dthomson25 deleted the fix-measurements branch November 6, 2019 01:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants