Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add get/retry experiment commands. Support experiment retries #263

Merged
merged 2 commits into from
Nov 6, 2019

Conversation

jessesuen
Copy link
Member

image

  • Add kubectl argo rollouts get experiment NAME
  • Add kubectl argo rollouts retry experiment NAME

Support retrying experiments by using a collision counter for analysis runs in experiments.

@jessesuen jessesuen requested a review from dthomson25 November 5, 2019 08:45
@codecov
Copy link

codecov bot commented Nov 5, 2019

Codecov Report

Merging #263 into master will decrease coverage by 0.19%.
The diff coverage is 81.14%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master    #263     +/-   ##
========================================
- Coverage   83.69%   83.5%   -0.2%     
========================================
  Files          59      61      +2     
  Lines        5306    5475    +169     
========================================
+ Hits         4441    4572    +131     
- Misses        632     664     +32     
- Partials      233     239      +6
Impacted Files Coverage Δ
pkg/kubectl-argo-rollouts/info/info.go 100% <ø> (ø) ⬆️
pkg/kubectl-argo-rollouts/info/pod_info.go 50.48% <100%> (+0.48%) ⬆️
pkg/kubectl-argo-rollouts/info/replicaset_info.go 79.1% <100%> (+0.31%) ⬆️
pkg/kubectl-argo-rollouts/info/rollout_info.go 74.26% <100%> (+0.19%) ⬆️
experiments/experiment.go 93.95% <100%> (+0.77%) ⬆️
pkg/kubectl-argo-rollouts/info/analysisrun_info.go 78.57% <100%> (+0.79%) ⬆️
rollout/analysis.go 88.81% <100%> (+1.02%) ⬆️
pkg/kubectl-argo-rollouts/cmd/retry/retry.go 100% <100%> (ø) ⬆️
...kg/kubectl-argo-rollouts/cmd/get/get_experiment.go 62.35% <62.35%> (ø)
pkg/kubectl-argo-rollouts/info/experiment_info.go 63.76% <77.27%> (+4.3%) ⬆️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 08112e1...366ed38. Read the comment docs.

@jessesuen jessesuen force-pushed the kubectl-rollout-get-exp branch from 782337f to 6dc07e0 Compare November 5, 2019 10:50
Copy link
Member

@dthomson25 dthomson25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added small comments. I wanted to look at the codecov before approving, but the website isn't loading atm.

pkg/kubectl-argo-rollouts/cmd/get/get.go Outdated Show resolved Hide resolved
pkg/kubectl-argo-rollouts/cmd/get/get_experiment.go Outdated Show resolved Hide resolved
pkg/kubectl-argo-rollouts/cmd/get/get_rollout.go Outdated Show resolved Hide resolved
pkg/kubectl-argo-rollouts/cmd/retry/retry.go Outdated Show resolved Hide resolved
@@ -1 +1 @@
0.5.0
0.6.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this intentional?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes

Copy link
Member

@dthomson25 dthomson25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jessesuen jessesuen merged commit 55c7875 into argoproj:master Nov 6, 2019
@jessesuen jessesuen deleted the kubectl-rollout-get-exp branch November 6, 2019 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants