Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use deterministic names for analysisruns created in experiments #259

Merged

Conversation

jessesuen
Copy link
Member

This change makes analysis runs created from experiments deterministic.

Builds on #258. Look at last commit only.

@jessesuen jessesuen changed the title Deterministic analysisrun names Use deterministic names for analysisruns created in experiments Nov 3, 2019
@jessesuen jessesuen force-pushed the deterministic-analysisrun-names branch from 124b97f to c3c1a73 Compare November 3, 2019 09:22
@codecov
Copy link

codecov bot commented Nov 3, 2019

Codecov Report

Merging #259 into master will decrease coverage by 0.01%.
The diff coverage is 78.57%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #259      +/-   ##
==========================================
- Coverage   83.55%   83.53%   -0.02%     
==========================================
  Files          59       59              
  Lines        5289     5301      +12     
==========================================
+ Hits         4419     4428       +9     
- Misses        634      636       +2     
- Partials      236      237       +1
Impacted Files Coverage Δ
experiments/experiment.go 93.17% <78.57%> (-0.78%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff94fbc...7b2d22f. Read the comment docs.

@jessesuen jessesuen force-pushed the deterministic-analysisrun-names branch 2 times, most recently from 1291a49 to 1342d2c Compare November 4, 2019 10:54
Copy link
Member

@dthomson25 dthomson25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jessesuen jessesuen force-pushed the deterministic-analysisrun-names branch from 1342d2c to d375534 Compare November 4, 2019 23:50
@jessesuen jessesuen force-pushed the deterministic-analysisrun-names branch from d375534 to 7b2d22f Compare November 5, 2019 00:57
@jessesuen jessesuen merged commit 8be0680 into argoproj:master Nov 5, 2019
@jessesuen jessesuen deleted the deterministic-analysisrun-names branch November 5, 2019 01:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants