Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add link to conventional pr check in pr template #2346

Merged
merged 1 commit into from
Oct 18, 2022

Conversation

zachaller
Copy link
Collaborator

Signed-off-by: zachaller zachaller@users.noreply.github.com

Signed-off-by: zachaller <zachaller@users.noreply.github.com>
@sonarcloud
Copy link

sonarcloud bot commented Oct 18, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
2.3% 2.3% Duplication

@zachaller zachaller added the ready-for-review Ready for final review label Oct 18, 2022
@github-actions
Copy link
Contributor

Go Published Test Results

1 778 tests   1 778 ✔️  2m 30s ⏱️
   101 suites         0 💤
       1 files           0

Results for commit adf345a.

@codecov
Copy link

codecov bot commented Oct 18, 2022

Codecov Report

Base: 82.76% // Head: 82.76% // No change to project coverage 👍

Coverage data is based on head (adf345a) compared to base (a247080).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2346   +/-   ##
=======================================
  Coverage   82.76%   82.76%           
=======================================
  Files         121      121           
  Lines       18522    18522           
=======================================
  Hits        15330    15330           
  Misses       2408     2408           
  Partials      784      784           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link
Contributor

E2E Tests Published Test Results

89 tests   86 ✔️  45m 10s ⏱️
  1 suites    3 💤
  1 files      0

Results for commit adf345a.

@mayzhang2000 mayzhang2000 merged commit fd6dcc1 into argoproj:master Oct 18, 2022
jenciso pushed a commit to jenciso/argo-rollouts that referenced this pull request Oct 25, 2022
Signed-off-by: zachaller <zachaller@users.noreply.github.com>

Signed-off-by: zachaller <zachaller@users.noreply.github.com>
jandersen-plaid pushed a commit to jandersen-plaid/argo-rollouts that referenced this pull request Nov 8, 2022
Signed-off-by: zachaller <zachaller@users.noreply.github.com>

Signed-off-by: zachaller <zachaller@users.noreply.github.com>
jandersen-plaid pushed a commit to jandersen-plaid/argo-rollouts that referenced this pull request Nov 26, 2022
Signed-off-by: zachaller <zachaller@users.noreply.github.com>

Signed-off-by: zachaller <zachaller@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-review Ready for final review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants