chore: upgrade golang to 1.19 #2219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: zachaller <zachaller@hotmail.com>
Signed-off-by: zachaller <zachaller@hotmail.com>
Signed-off-by: zachaller <zachaller@hotmail.com>
Codecov Report
@@ Coverage Diff @@
## master #2219 +/- ##
==========================================
- Coverage 82.39% 82.37% -0.02%
==========================================
Files 121 121
Lines 18099 18099
==========================================
- Hits 14912 14909 -3
- Misses 2417 2419 +2
- Partials 770 771 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Signed-off-by: zachaller <zachaller@hotmail.com>
Signed-off-by: zachaller <zachaller@hotmail.com>
Signed-off-by: zachaller <zachaller@hotmail.com>
|
Kudos, SonarCloud Quality Gate passed!
|
leoluz
reviewed
Oct 4, 2022
| @@ -13,9 +13,7 @@ linters: | |||
| - vet | |||
| - gofmt | |||
| - goimports | |||
| - deadcode | |||
| - varcheck | |||
| - structcheck | |||
There was a problem hiding this comment.
can you confirm why removing varcheck, structcheck and deadcode? Is this all covered by unused I'm assuming?
There was a problem hiding this comment.
They are deprecated and have moved into unused.
leoluz
approved these changes
Oct 4, 2022
jenciso
pushed a commit
to jenciso/argo-rollouts
that referenced
this pull request
Oct 25, 2022
* chore: upgrade golang to 1.19 Signed-off-by: zachaller <zachaller@hotmail.com> * Upgrade golangci-lint Signed-off-by: zachaller <zachaller@hotmail.com> * Upgrade golangci-lint in github action Signed-off-by: zachaller <zachaller@hotmail.com> * fix linting Signed-off-by: zachaller <zachaller@hotmail.com> * Add nolint to test functions Signed-off-by: zachaller <zachaller@hotmail.com> * Cleanup Signed-off-by: zachaller <zachaller@hotmail.com> * github trigger re-run Signed-off-by: zachaller <zachaller@hotmail.com> Signed-off-by: zachaller <zachaller@hotmail.com>
jandersen-plaid
pushed a commit
to jandersen-plaid/argo-rollouts
that referenced
this pull request
Nov 8, 2022
* chore: upgrade golang to 1.19 Signed-off-by: zachaller <zachaller@hotmail.com> * Upgrade golangci-lint Signed-off-by: zachaller <zachaller@hotmail.com> * Upgrade golangci-lint in github action Signed-off-by: zachaller <zachaller@hotmail.com> * fix linting Signed-off-by: zachaller <zachaller@hotmail.com> * Add nolint to test functions Signed-off-by: zachaller <zachaller@hotmail.com> * Cleanup Signed-off-by: zachaller <zachaller@hotmail.com> * github trigger re-run Signed-off-by: zachaller <zachaller@hotmail.com> Signed-off-by: zachaller <zachaller@hotmail.com>
jandersen-plaid
pushed a commit
to jandersen-plaid/argo-rollouts
that referenced
this pull request
Nov 26, 2022
* chore: upgrade golang to 1.19 Signed-off-by: zachaller <zachaller@hotmail.com> * Upgrade golangci-lint Signed-off-by: zachaller <zachaller@hotmail.com> * Upgrade golangci-lint in github action Signed-off-by: zachaller <zachaller@hotmail.com> * fix linting Signed-off-by: zachaller <zachaller@hotmail.com> * Add nolint to test functions Signed-off-by: zachaller <zachaller@hotmail.com> * Cleanup Signed-off-by: zachaller <zachaller@hotmail.com> * github trigger re-run Signed-off-by: zachaller <zachaller@hotmail.com> Signed-off-by: zachaller <zachaller@hotmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: zachaller zachaller@hotmail.com
Checklist:
"fix(controller): Updates such and such. Fixes #1234".