Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fixed NPE while getting the ReplicaSet labels #1664

Merged
merged 1 commit into from
Nov 18, 2021

Conversation

agrawroh
Copy link
Member

@agrawroh agrawroh commented Nov 18, 2021

Description

This PR fixes a NPE which gets thrown while getting the ReplicaSet labels if the RS itself is null. See #1630 for more details.

Checklist

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I've signed my commits with DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My builds are green. Try syncing with master if they are not.
  • My organization is added to USERS.md.

Signed-off-by: Rohit Agrawal rohit.agrawal@databricks.com

Signed-off-by: Rohit Agrawal <rohit.agrawal@databricks.com>
@sonarcloud
Copy link

sonarcloud bot commented Nov 18, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
7.1% 7.1% Duplication

@codecov
Copy link

codecov bot commented Nov 18, 2021

Codecov Report

Merging #1664 (2572a7a) into master (6edc9c8) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1664      +/-   ##
==========================================
- Coverage   81.99%   81.97%   -0.02%     
==========================================
  Files         115      115              
  Lines       15913    15913              
==========================================
- Hits        13048    13045       -3     
- Misses       2196     2198       +2     
- Partials      669      670       +1     
Impacted Files Coverage Δ
utils/replicaset/replicaset.go 90.04% <100.00%> (ø)
rollout/trafficrouting/istio/controller.go 50.81% <0.00%> (-1.63%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6edc9c8...2572a7a. Read the comment docs.

Copy link
Contributor

@alexmt alexmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexmt alexmt merged commit 55c70a1 into argoproj:master Nov 18, 2021
alexmt pushed a commit that referenced this pull request Nov 29, 2021
Signed-off-by: Rohit Agrawal <rohit.agrawal@databricks.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants