Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: viewcontroller gorouting leak in status and get subcommand #1584

Merged
merged 2 commits into from
Oct 17, 2021

Conversation

huikang
Copy link
Member

@huikang huikang commented Oct 14, 2021

Signed-off-by: Hui Kang hui.kang@salesforce.com

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I've signed my commits with DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My builds are green. Try syncing with master if they are not.
  • My organization is added to USERS.md.

Signed-off-by: Hui Kang <hui.kang@salesforce.com>
Signed-off-by: Hui Kang <hui.kang@salesforce.com>
@sonarcloud
Copy link

sonarcloud bot commented Oct 14, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Oct 14, 2021

Codecov Report

Merging #1584 (fd171c2) into master (f07de59) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1584   +/-   ##
=======================================
  Coverage   81.76%   81.76%           
=======================================
  Files         112      112           
  Lines       15117    15120    +3     
=======================================
+ Hits        12360    12363    +3     
  Misses       2110     2110           
  Partials      647      647           
Impacted Files Coverage Δ
pkg/kubectl-argo-rollouts/cmd/get/get_rollout.go 98.49% <100.00%> (+0.01%) ⬆️
pkg/kubectl-argo-rollouts/cmd/status/status.go 93.33% <100.00%> (+0.09%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f07de59...fd171c2. Read the comment docs.

@jessesuen jessesuen merged commit 76c1b3e into argoproj:master Oct 17, 2021
@jessesuen
Copy link
Member

Nice catch!

alexmt pushed a commit that referenced this pull request Nov 29, 2021
Signed-off-by: Hui Kang <hui.kang@salesforce.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants