Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: inconsistent status command output #1433

Merged
merged 2 commits into from
Nov 5, 2021
Merged

fix: inconsistent status command output #1433

merged 2 commits into from
Nov 5, 2021

Conversation

huikang
Copy link
Member

@huikang huikang commented Aug 19, 2021

Signed-off-by: Hui Kang hui.kang@salesforce.com

close #1391

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I've signed my commits with DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My builds are green. Try syncing with master if they are not.
  • My organization is added to USERS.md.

@huikang huikang force-pushed the 1391-inconsistent-command-output branch from 550f853 to 03a8142 Compare August 19, 2021 19:35
@codecov
Copy link

codecov bot commented Aug 19, 2021 •
edited
Loading

Codecov Report

Merging #1433 (35fdef1) into master (9d2ccb9) will increase coverage by 0.16%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1433      +/-   ##
==========================================
+ Coverage   81.77%   81.93%   +0.16%     
==========================================
  Files         113      115       +2     
  Lines       15573    15861     +288     
==========================================
+ Hits        12735    12996     +261     
- Misses       2176     2196      +20     
- Partials      662      669       +7
Impacted Files Coverage Δ
controller/controller.go 89.45% <100.00%> (ø)
controller/healthz.go 100.00% <100.00%> (ø)
controller/metrics/metrics.go 100.00% <100.00%> (ø)
pkg/kubectl-argo-rollouts/cmd/status/status.go 93.75% <100.00%> (+0.41%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6b2b375...35fdef1. Read the comment docs.

@huikang huikang force-pushed the 1391-inconsistent-command-output branch from 03a8142 to c12d5fa Compare September 14, 2021 01:40
@sonarcloud
Copy link

sonarcloud bot commented Sep 14, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
10.3% 10.3% Duplication

@huikang
Copy link
Member Author

huikang commented Sep 14, 2021

New outputs

kubectl-argo-rollouts-darwin-amd64 status rollouts-demo --watch=true
Progressing - more replicas need to be updated
Progressing - more replicas need to be updated
Progressing - more replicas need to be updated
Paused - CanaryPauseStep

kubectl-argo-rollouts-darwin-amd64 status rollouts-demo --watch=false
Progressing - more replicas need to be updated


kubectl-argo-rollouts-darwin-amd64 status rollouts-demo --watch=true
Paused - CanaryPauseStep

kubectl-argo-rollouts-darwin-amd64 status rollouts-demo --watch=false
Paused - CanaryPauseStep

This was referenced Sep 14, 2021
Closed
Closed
@harikrongali harikrongali added the ready-for-review Ready for final review label Oct 22, 2021
@huikang huikang force-pushed the 1391-inconsistent-command-output branch 3 times, most recently from 3283d50 to fd01978 Compare October 27, 2021 01:18
@huikang huikang force-pushed the 1391-inconsistent-command-output branch from fd01978 to 7d1d318 Compare November 4, 2021 19:01
@huikang huikang removed the request for review from jessesuen November 4, 2021 19:01
fix: inconsistent status command outputs
1f3fc14 
- unit test updated

Signed-off-by: Hui Kang <hui.kang@salesforce.com>
@huikang huikang force-pushed the 1391-inconsistent-command-output branch 6 times, most recently from 38bfb39 to c08faf1 Compare November 5, 2021 02:04
fix: unit test updated to ingressWrapper
35fdef1 
Signed-off-by: Hui Kang <hui.kang@salesforce.com>
@huikang huikang force-pushed the 1391-inconsistent-command-output branch from c08faf1 to 35fdef1 Compare November 5, 2021 03:14
@sonarcloud
Copy link

sonarcloud bot commented Nov 5, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
15.6% 15.6% Duplication

@jessesuen jessesuen merged commit 75cdde7 into argoproj:master Nov 5, 2021
alexmt pushed a commit that referenced this pull request Nov 29, 2021
@huikang @alexmt
fix: inconsistent status command output (#1433)
2f2bcea 
Signed-off-by: Hui Kang <hui.kang@salesforce.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harikrongali harikrongali harikrongali approved these changes

@jessesuen jessesuen jessesuen approved these changes

@alexmt alexmt alexmt approved these changes

Assignees
No one assigned
Labels
ready-for-review Ready for final review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Status command output differs depending on the flag is set as --watch=true or --watch=false
4 participants
@huikang @alexmt @jessesuen @harikrongali