Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: analysis runs to wait for all metrics to complete #1407

Merged
merged 3 commits into from
Aug 17, 2021

Conversation

harikrongali
Copy link
Contributor

Signed-off-by: hari rongali hari_rongali@intuit.com

fixes #1360

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I've signed my commits with DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My builds are green. Try syncing with master if they are not.
  • My organization is added to USERS.md.

Signed-off-by: hari rongali <hari_rongali@intuit.com>
@harikrongali harikrongali changed the title fix: fix analysis metrics to wait for all metrics to complete fix: analysis runs to wait for all metrics to complete Aug 10, 2021
Signed-off-by: hari rongali <hari_rongali@intuit.com>
Signed-off-by: hari rongali <hari_rongali@intuit.com>
@sonarcloud
Copy link

sonarcloud bot commented Aug 11, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Aug 11, 2021

Codecov Report

Merging #1407 (86d3e88) into master (7a0704a) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1407      +/-   ##
==========================================
- Coverage   81.27%   81.25%   -0.03%     
==========================================
  Files         108      108              
  Lines        9950     9955       +5     
==========================================
+ Hits         8087     8089       +2     
- Misses       1309     1311       +2     
- Partials      554      555       +1     
Impacted Files Coverage Δ
analysis/analysis.go 85.87% <100.00%> (-0.68%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf19b5b...86d3e88. Read the comment docs.

Copy link
Member

@jessesuen jessesuen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix!

@jessesuen jessesuen merged commit 85ed2b9 into argoproj:master Aug 17, 2021
jessesuen pushed a commit that referenced this pull request Aug 23, 2021
Signed-off-by: hari rongali <hari_rongali@intuit.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

inline analysis doesnt wait for all metrics to run
2 participants