-
Notifications
You must be signed in to change notification settings - Fork 873
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for Graphite metrics provider #1406
feat: add support for Graphite metrics provider #1406
Commits on Aug 10, 2021
-
feat: add support for Graphite metrics provider
Address issue argoproj#1403 by adding a Graphite metrics provider. Signed-off-by: Mike Ball <mikedball@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 8f4eb59 - Browse repository at this point
Copy the full SHA 8f4eb59View commit details -
add Graphite metric provider documentation
Signed-off-by: Mike Ball <mikedball@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for d1c71ac - Browse repository at this point
Copy the full SHA d1c71acView commit details
Commits on Aug 25, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 2307323 - Browse repository at this point
Copy the full SHA 2307323View commit details -
correct MetricProvider.Graphite protobuf bytes
Signed-off-by: Mike Ball <mikedball@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for d86143b - Browse repository at this point
Copy the full SHA d86143bView commit details -
correct code comment typo to reference 'Graphite'
Signed-off-by: Mike Ball <mikedball@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 2498ab4 - Browse repository at this point
Copy the full SHA 2498ab4View commit details -
use custom HTTP client w/ 10s timeout
Per code review feedback... > It's a bad idea to use the golang HTTP default client because of possibility of hung connections, since it does not timeout As outlined here: https://medium.com/@nate510/don-t-use-go-s-default-http-client-4804cb19f779 The 10s timeout matches the default of the webmetric provider's HTTP client. Signed-off-by: Mike Ball <mikedball@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 71f086e - Browse repository at this point
Copy the full SHA 71f086eView commit details -
remove accidentally-commited coverage file
Signed-off-by: Mike Ball <mikedball@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 353150d - Browse repository at this point
Copy the full SHA 353150dView commit details
Commits on Aug 27, 2021
-
graphite.API#Query returns []dataPoint
Previously, `graphite.API#Query` returned the value of the last item in the `datapoints` array returned by the Graphite API. However, this somewhat diverged from the Prometheus metricprovider implementation and fails to consider a use case for obtaining the first or an arbitrary element from the datapoints array, as discussed here: argoproj#1406 (comment) Signed-off-by: Mike Ball <mikedball@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 91e32aa - Browse repository at this point
Copy the full SHA 91e32aaView commit details
Commits on Aug 30, 2021
-
remove trailing whitespace from CONTRIBUTING.md
Signed-off-by: Mike Ball <mikedball@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 858b61f - Browse repository at this point
Copy the full SHA 858b61fView commit details -
add 'make codegen'-generated files
Signed-off-by: Mike Ball <mikedball@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for cb56197 - Browse repository at this point
Copy the full SHA cb56197View commit details -
test for null value in Graphite API response
Signed-off-by: Mike Ball <mikedball@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 37dc91d - Browse repository at this point
Copy the full SHA 37dc91dView commit details
Commits on Sep 3, 2021
-
Merge remote-tracking branch 'origin/master' into 1403-graphite-metri…
…cs-provider Signed-off-by: Mike Ball <mikedball@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 47c101b - Browse repository at this point
Copy the full SHA 47c101bView commit details
Commits on Sep 20, 2021
-
Merge branch 'master' into 1403-graphite-metrics-provider
Signed-off-by: Jesse Suen <jessesuen@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 3558d5d - Browse repository at this point
Copy the full SHA 3558d5dView commit details