Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for Graphite metrics provider #1406

Merged
merged 13 commits into from
Sep 20, 2021

Commits on Aug 10, 2021

  1. feat: add support for Graphite metrics provider

    Address issue argoproj#1403 by adding a Graphite
    metrics provider.
    
    Signed-off-by: Mike Ball <mikedball@gmail.com>
    mdb committed Aug 10, 2021
    Configuration menu
    Copy the full SHA
    8f4eb59 View commit details
    Browse the repository at this point in the history
  2. add Graphite metric provider documentation

    Signed-off-by: Mike Ball <mikedball@gmail.com>
    mdb committed Aug 10, 2021
    Configuration menu
    Copy the full SHA
    d1c71ac View commit details
    Browse the repository at this point in the history

Commits on Aug 25, 2021

  1. Configuration menu
    Copy the full SHA
    2307323 View commit details
    Browse the repository at this point in the history
  2. correct MetricProvider.Graphite protobuf bytes

    Signed-off-by: Mike Ball <mikedball@gmail.com>
    mdb committed Aug 25, 2021
    Configuration menu
    Copy the full SHA
    d86143b View commit details
    Browse the repository at this point in the history
  3. correct code comment typo to reference 'Graphite'

    Signed-off-by: Mike Ball <mikedball@gmail.com>
    mdb committed Aug 25, 2021
    Configuration menu
    Copy the full SHA
    2498ab4 View commit details
    Browse the repository at this point in the history
  4. use custom HTTP client w/ 10s timeout

    Per code review feedback...
    
    > It's a bad idea to use the golang HTTP default client because of possibility of hung connections, since it does not timeout
    
    As outlined here:
    https://medium.com/@nate510/don-t-use-go-s-default-http-client-4804cb19f779
    
    The 10s timeout matches the default of the webmetric provider's HTTP client.
    
    Signed-off-by: Mike Ball <mikedball@gmail.com>
    mdb committed Aug 25, 2021
    Configuration menu
    Copy the full SHA
    71f086e View commit details
    Browse the repository at this point in the history
  5. remove accidentally-commited coverage file

    Signed-off-by: Mike Ball <mikedball@gmail.com>
    mdb committed Aug 25, 2021
    Configuration menu
    Copy the full SHA
    353150d View commit details
    Browse the repository at this point in the history

Commits on Aug 27, 2021

  1. graphite.API#Query returns []dataPoint

    Previously, `graphite.API#Query` returned the value of
    the last item in the `datapoints` array returned by
    the Graphite API. However, this somewhat diverged from
    the Prometheus metricprovider implementation and fails
    to consider a use case for obtaining the first or an
    arbitrary element from the datapoints array, as
    discussed here:
    
    argoproj#1406 (comment)
    
    Signed-off-by: Mike Ball <mikedball@gmail.com>
    mdb committed Aug 27, 2021
    Configuration menu
    Copy the full SHA
    91e32aa View commit details
    Browse the repository at this point in the history

Commits on Aug 30, 2021

  1. remove trailing whitespace from CONTRIBUTING.md

    Signed-off-by: Mike Ball <mikedball@gmail.com>
    mdb committed Aug 30, 2021
    Configuration menu
    Copy the full SHA
    858b61f View commit details
    Browse the repository at this point in the history
  2. add 'make codegen'-generated files

    Signed-off-by: Mike Ball <mikedball@gmail.com>
    mdb committed Aug 30, 2021
    Configuration menu
    Copy the full SHA
    cb56197 View commit details
    Browse the repository at this point in the history
  3. test for null value in Graphite API response

    Signed-off-by: Mike Ball <mikedball@gmail.com>
    mdb committed Aug 30, 2021
    Configuration menu
    Copy the full SHA
    37dc91d View commit details
    Browse the repository at this point in the history

Commits on Sep 3, 2021

  1. Merge remote-tracking branch 'origin/master' into 1403-graphite-metri…

    …cs-provider
    
    Signed-off-by: Mike Ball <mikedball@gmail.com>
    mdb committed Sep 3, 2021
    Configuration menu
    Copy the full SHA
    47c101b View commit details
    Browse the repository at this point in the history

Commits on Sep 20, 2021

  1. Merge branch 'master' into 1403-graphite-metrics-provider

    Signed-off-by: Jesse Suen <jessesuen@gmail.com>
    jessesuen committed Sep 20, 2021
    Configuration menu
    Copy the full SHA
    3558d5d View commit details
    Browse the repository at this point in the history