Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: ability to abort an update when exceeding progressDeadlineSeconds #1397

Merged
merged 7 commits into from
Aug 23, 2021
Merged

feat: ability to abort an update when exceeding progressDeadlineSeconds #1397

merged 7 commits into from
Aug 23, 2021

Commits on Aug 12, 2021

  1. feat: scaledown rs when update exceeds progressDeadlineSeconds 

    - Add AbortExceedProgressDeadline to rollout spec
- when rollout doesn't use analysis, set AbortExceedProgressDeadline
  to true to scale down the new RS.
- e2e test added

Signed-off-by: Hui Kang <hui.kang@salesforce.com>
    Hui Kang committed Aug 12, 2021
    Configuration menu
    Copy the full SHA
    ac8f53a View commit details
    Browse the repository at this point in the history

  2. Rename to progressDeadlineAbort and add abort to the right case 

    Signed-off-by: Hui Kang <hui.kang@salesforce.com>
    Hui Kang committed Aug 12, 2021
    Configuration menu
    Copy the full SHA
    9f9f83d View commit details
    Browse the repository at this point in the history

  3. Fix: always set Progressing=false on timeout and event record 

    Signed-off-by: Hui Kang <hui.kang@salesforce.com>
    Hui Kang committed Aug 12, 2021
    Configuration menu
    Copy the full SHA
    bc25d10 View commit details
    Browse the repository at this point in the history

Commits on Aug 14, 2021

  1. add condition of abort and event emission 

    Signed-off-by: Hui Kang <hui.kang@salesforce.com>
    Hui Kang committed Aug 14, 2021
    Configuration menu
    Copy the full SHA
    4cf719a View commit details
    Browse the repository at this point in the history

Commits on Aug 20, 2021

  1. Update docs/features/specification.md 

    Co-authored-by: Kyle Cronin <cronik@users.noreply.github.com>

Signed-off-by: Hui Kang <hui.kang@salesforce.com>
    @huikang
    huikang authored and Hui Kang committed Aug 20, 2021
    Configuration menu
    Copy the full SHA
    fd8df42 View commit details
    Browse the repository at this point in the history

Commits on Aug 21, 2021

  1. unit test for timeout abort 

    Signed-off-by: Hui Kang <hui.kang@salesforce.com>
    Hui Kang committed Aug 21, 2021
    Configuration menu
    Copy the full SHA
    4e4484b View commit details
    Browse the repository at this point in the history

Commits on Aug 22, 2021

  1. Consolidate test cases to reduce duplication 

    Signed-off-by: Hui Kang <hui.kang@salesforce.com>
    Hui Kang committed Aug 22, 2021
    Configuration menu
    Copy the full SHA
    0cfdf29 View commit details
    Browse the repository at this point in the history