Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: github release action was using incorect docker cache #1387

Merged
merged 1 commit into from
Aug 2, 2021

Conversation

jessesuen
Copy link
Member

Signed-off-by: Jesse Suen jesse_suen@intuit.com

@codecov
Copy link

codecov bot commented Aug 2, 2021

Codecov Report

Merging #1387 (a3f4eb3) into master (ff3569d) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1387   +/-   ##
=======================================
  Coverage   81.22%   81.22%           
=======================================
  Files         108      108           
  Lines        9916     9916           
=======================================
  Hits         8054     8054           
  Misses       1309     1309           
  Partials      553      553           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff3569d...a3f4eb3. Read the comment docs.

@jessesuen jessesuen force-pushed the fix-docker-cache branch 5 times, most recently from f87e47c to 1c62248 Compare August 2, 2021 23:16
Signed-off-by: Jesse Suen <jesse_suen@intuit.com>
@sonarcloud
Copy link

sonarcloud bot commented Aug 2, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
2.1% 2.1% Duplication

Copy link
Contributor

@alexmt alexmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jessesuen jessesuen merged commit 2600c6a into argoproj:master Aug 2, 2021
@jessesuen jessesuen deleted the fix-docker-cache branch August 2, 2021 23:37
jessesuen added a commit that referenced this pull request Aug 2, 2021
Signed-off-by: Jesse Suen <jesse_suen@intuit.com>
mdb pushed a commit to mdb/argo-rollouts that referenced this pull request Aug 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants