Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Promote full did not work against BlueGreen with previewReplicaCount #1384

Merged
merged 1 commit into from
Jul 30, 2021
Merged

fix: Promote full did not work against BlueGreen with previewReplicaCount #1384

merged 1 commit into from
Jul 30, 2021

Conversation

jessesuen
Copy link
Member

Resolves #1383

Signed-off-by: Jesse Suen jesse_suen@intuit.com

@jessesuen jessesuen requested a review from alexmt July 30, 2021 22:13
alexmt
alexmt approved these changes Jul 30, 2021
View reviewed changes
Copy link
Contributor

@alexmt alexmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Thanks for documenting NewRSNewReplicas as well - it is much easier to understand edge cases in this function now!

@jessesuen
fix: Promote full did not work against BlueGreen with previewReplicaC…
ca4acb8 
…ount

Signed-off-by: Jesse Suen <jesse_suen@intuit.com>
@jessesuen jessesuen force-pushed the issue-1383-previewReplicasPromoteFull branch from a3504f8 to ca4acb8 Compare July 30, 2021 22:49
@sonarcloud
Copy link

sonarcloud bot commented Jul 30, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
2.1% 2.1% Duplication

@codecov
Copy link

codecov bot commented Jul 30, 2021

Codecov Report

Merging #1384 (ca4acb8) into master (43eaf3c) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1384   +/-   ##
=======================================
  Coverage   81.21%   81.22%           
=======================================
  Files         108      108           
  Lines        9913     9916    +3     
=======================================
+ Hits         8051     8054    +3     
  Misses       1309     1309           
  Partials      553      553
Impacted Files Coverage Δ
utils/replicaset/replicaset.go 89.58% <100.00%> (+0.10%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 43eaf3c...ca4acb8. Read the comment docs.

@jessesuen jessesuen merged commit ff3569d into argoproj:master Jul 30, 2021
@jessesuen jessesuen deleted the issue-1383-previewReplicasPromoteFull branch July 30, 2021 23:25
jessesuen added a commit that referenced this pull request Jul 30, 2021
@jessesuen
fix: Promote full did not work against BlueGreen with previewReplicaC…
c63b6c1 
…ount (#1384)

Signed-off-by: Jesse Suen <jesse_suen@intuit.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexmt alexmt alexmt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Promote full did not work against BlueGreen with previewReplicaCount
2 participants
@jessesuen @alexmt