Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: example dashboard - add rollout stat row #1343

Merged
merged 1 commit into from
Jul 14, 2021

Conversation

huikang
Copy link
Member

@huikang huikang commented Jul 13, 2021

  • Switch to stat panel
  • fix missing labels in some metrics on example dashboard
  • add job label to avoid interference with service discovery results
  • replace deprecated rollout_phase with rollout_info

Signed-off-by: Hui Kang hui.kang@salesforce.com

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I've signed my commits with DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My builds are green. Try syncing with master if they are not.
  • My organization is added to USERS.md.

- Switch to stat panel
- fix missing labels in some metrics on example dashboard
- add job label to avoid interference with service discovery results
- replace deprecated rollout_phase with rollout_info

Signed-off-by: Hui Kang <hui.kang@salesforce.com>
@sonarcloud
Copy link

sonarcloud bot commented Jul 13, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
9.6% 9.6% Duplication

@huikang
Copy link
Member Author

huikang commented Jul 13, 2021

  • Landing page

Screen Shot 2021-07-13 at 1 17 28 PM

  • controller stat

Screen Shot 2021-07-13 at 1 17 46 PM

  • rollout stat 1 for selected rollout

Screen Shot 2021-07-13 at 1 18 27 PM

  • rollout stat 2 for selected rollout

Screen Shot 2021-07-13 at 1 18 01 PM

@codecov
Copy link

codecov bot commented Jul 13, 2021

Codecov Report

Merging #1343 (c788a57) into master (e6bae87) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1343   +/-   ##
=======================================
  Coverage   81.27%   81.27%           
=======================================
  Files         107      107           
  Lines        9824     9824           
=======================================
  Hits         7984     7984           
  Misses       1297     1297           
  Partials      543      543           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e6bae87...c788a57. Read the comment docs.

@jessesuen jessesuen merged commit 21c7826 into argoproj:master Jul 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants