feat: argo rollout compatibility with emissary and edge stack v2.0

[acookin]

Signed-off-by: Alix Cook alixcook@datawire.io

Allow argo rollouts to work with emissary and edge stack v2, recently announced as developer preview.
See our release notes for more information.

I'd like to merge this feature, and then update our docs and the argo-docs in a subsequent PR so that I don't have to worry about releasing these things in lockstep.

Checklist:

• Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
• The title of the PR is (a) conventional, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
• I've signed my commits with DCO
• I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
• My builds are green. Try syncing with master if they are not.
• My organization is added to USERS.md.

[codecov]

Codecov Report

Merging #1330 (1a0922e) into master (503c520) will decrease coverage by 0.13%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1330      +/-   ##
==========================================
- Coverage   81.40%   81.27%   -0.14%     
==========================================
  Files         106      107       +1     
  Lines        9778     9824      +46     
==========================================
+ Hits         7960     7984      +24     
- Misses       1278     1297      +19     
- Partials      540      543       +3     

Impacted Files	Coverage Δ
utils/defaults/defaults.go	85.71% <ø> (ø)
rollout/trafficrouting/ambassador/ambassador.go	84.28% <100.00%> (+0.70%)	⬆️
rollout/controller.go	78.35% <0.00%> (ø)
utils/istio/multicluster.go	45.00% <0.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 503c520...1a0922e. Read the comment docs.

[jessesuen]

Do you want to update the ambassador docs to say Emissary / Edge Stack v2.0 is supported with the --ambassador-api-version x.getambassador.io/v3alpha1 (with an "available since v1.1" caveat).

[jessesuen]

So it seems this change now accepts API version with or without the group in it. e.g.:

rollouts-controller --ambassador-api-version v2
rollouts-controller --ambassador-api-version getambassador.io/v2
rollouts-controller --ambassador-api-version x.getambassador.io/v3alpha1

Now that we support supplying a different group, can we change DefaultAmbassadorVersion to be getambassador.io/v2 so that when users see the --help of the rollout controller, they know that this is possible?

[acookin]

makes sense.

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
38.0% Duplication