Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add liveness and readiness probe to install manifest #1324

Merged
merged 1 commit into from
Jul 7, 2021

Conversation

huikang
Copy link
Member

@huikang huikang commented Jul 3, 2021

Signed-off-by: Hui Kang hui.kang@salesforce.com

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I've signed my commits with DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My builds are green. Try syncing with master if they are not.
  • My organization is added to USERS.md.

@huikang huikang force-pushed the chore-manifest-add-deploy-check branch from 0c411b8 to a3c1d0d Compare July 3, 2021 17:59
@codecov
Copy link

codecov bot commented Jul 3, 2021

Codecov Report

Merging #1324 (d7874da) into master (d4c8aab) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1324   +/-   ##
=======================================
  Coverage   81.37%   81.37%           
=======================================
  Files         106      106           
  Lines        9721     9721           
=======================================
  Hits         7910     7910           
  Misses       1273     1273           
  Partials      538      538           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d4c8aab...d7874da. Read the comment docs.

Signed-off-by: Hui Kang <hui.kang@salesforce.com>
@huikang huikang force-pushed the chore-manifest-add-deploy-check branch from a3c1d0d to d7874da Compare July 5, 2021 22:03
@sonarcloud
Copy link

sonarcloud bot commented Jul 5, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@jessesuen jessesuen merged commit 503c520 into argoproj:master Jul 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants