Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: the wrong panel title of the sample dashboard #1260

Merged
merged 1 commit into from
Jun 9, 2021
Merged

fix: the wrong panel title of the sample dashboard #1260

merged 1 commit into from
Jun 9, 2021

Conversation

huikang
Copy link
Member

@huikang huikang commented Jun 8, 2021

Signed-off-by: Hui Kang hui.kang@salesforce.com

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I've signed my commits with DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My builds are green. Try syncing with master if they are not.
  • My organization is added to USERS.md.

fix: the wrong panel title on the sample dashboard
8659457 
Signed-off-by: Hui Kang <hui.kang@salesforce.com>
@sonarcloud
Copy link

sonarcloud bot commented Jun 8, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@huikang huikang changed the title fix: the wrong panel title on the sample dashboard fix: the wrong panel title of the sample dashboard Jun 8, 2021
@jessesuen jessesuen merged commit 99bd90e into argoproj:master Jun 9, 2021
caoyang001 pushed a commit to caoyang001/argo-rollouts that referenced this pull request Jun 12, 2021
@huikang @caoyang001
fix: the wrong panel title on the sample dashboard (argoproj#1260)
d5a1672 
Signed-off-by: Hui Kang <hui.kang@salesforce.com>
Signed-off-by: caoyang001 <caoyang001@foxmail.com>
perenesenko pushed a commit to perenesenko/argo-rollouts that referenced this pull request Jun 17, 2021
@huikang @perenesenko
fix: the wrong panel title on the sample dashboard (argoproj#1260)
5683e18 
Signed-off-by: Hui Kang <hui.kang@salesforce.com>
Signed-off-by: Andrii Perenesenko <andrii.perenesenko@gmail.com>
perenesenko pushed a commit to perenesenko/argo-rollouts that referenced this pull request Jun 22, 2021
@huikang @perenesenko
fix: the wrong panel title on the sample dashboard (argoproj#1260)
aaa2b7d 
Signed-off-by: Hui Kang <hui.kang@salesforce.com>
Signed-off-by: Andrii Perenesenko <andrii.perenesenko@gmail.com>
huikang added a commit to huikang/argo-rollouts that referenced this pull request Sep 16, 2021
@huikang
fix: the wrong panel title on the sample dashboard (argoproj#1260)
eac1bf5 
Signed-off-by: Hui Kang <hui.kang@salesforce.com>
Signed-off-by: caoyang001 <caoyang001@foxmail.com>
huikang added a commit to huikang/argo-rollouts that referenced this pull request Sep 16, 2021
@huikang
fix: the wrong panel title on the sample dashboard (argoproj#1260)
7b99cce 
Signed-off-by: Hui Kang <hui.kang@salesforce.com>
Signed-off-by: caoyang001 <caoyang001@foxmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jessesuen jessesuen jessesuen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@huikang @jessesuen