fix: AnalysisRun args could not be resolved from secret #1213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: khhirani <kareena.hirani@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #1213 +/- ##
==========================================
+ Coverage 81.09% 81.20% +0.11%
==========================================
Files 106 106
Lines 9519 9510 -9
==========================================
+ Hits 7719 7723 +4
+ Misses 1269 1260 -9
+ Partials 531 527 -4
Continue to review full report at Codecov.
|
…to fix-valuefrom-analysistemplate
Signed-off-by: khhirani <kareena.hirani@gmail.com>
Signed-off-by: khhirani <kareena.hirani@gmail.com>
khhirani
changed the title
Signed-off-by: khhirani <kareena.hirani@gmail.com>
Signed-off-by: khhirani <kareena.hirani@gmail.com>
Signed-off-by: khhirani <kareena.hirani@gmail.com>
jessesuen
changed the title
jessesuen
changed the title
jessesuen
approved these changes
May 24, 2021
Signed-off-by: khhirani <kareena.hirani@gmail.com>
|
Kudos, SonarCloud Quality Gate passed!
|
caoyang001
pushed a commit
to caoyang001/argo-rollouts
that referenced
this pull request
Jun 12, 2021
* fix: Fix ValueFrom resolution and validation in AnalysisTemplate Signed-off-by: caoyang001 <caoyang001@foxmail.com>
huikang
pushed a commit
to huikang/argo-rollouts
that referenced
this pull request
Sep 16, 2021
* fix: Fix ValueFrom resolution and validation in AnalysisTemplate Signed-off-by: caoyang001 <caoyang001@foxmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1205
Signed-off-by: khhirani kareena.hirani@gmail.com