feat: support notifications on rollout events using notifications-engine #1175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexmt
force-pushed
the
369-notifications-custom-triggers
branch
from
cb6ec2e
to
be26239
Compare
harikrongali
force-pushed
the
369-notifications-custom-triggers
branch
from
36bd0b9
to
32cf339
Compare
Codecov Report
@@ Coverage Diff @@
## master #1175 +/- ##
==========================================
- Coverage 83.97% 81.41% -2.57%
==========================================
Files 70 106 +36
Lines 6528 9702 +3174
==========================================
+ Hits 5482 7899 +2417
- Misses 750 1266 +516
- Partials 296 537 +241
Continue to review full report at Codecov.
|
alexmt
force-pushed
the
369-notifications-custom-triggers
branch
3 times, most recently
from
906f787
to
1407491
Compare
khhirani
reviewed
Jun 2, 2021
| slack-token: <my-slack-token> | ||
| ``` | ||
|
|
||
| Learn more about supported services and configuration settings in services [documentation](../generated/notification-services/overview.md). |
There was a problem hiding this comment.
link is referencing file is generated directory. So these files are not committed to git.
jessesuen
approved these changes
Jun 17, 2021
| @@ -0,0 +1,131 @@ | |||
| # Notifications | |||
There was a problem hiding this comment.
Add a note:
!!! important
Available since v1.1
There was a problem hiding this comment.
has v1.1 been released yet? i see that the release tags only go up to v1.0.2
jessesuen
changed the title
Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>
Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>
Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>
Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>
Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>
alexmt
force-pushed
the
369-notifications-custom-triggers
branch
from
fbeaaa5
to
2d5949e
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
perenesenko
pushed a commit
to perenesenko/argo-rollouts
that referenced
this pull request
Jun 22, 2021
…ine (argoproj#1175) feat: support notifications on rollout events using notifications-engine (argoproj#1175) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> Signed-off-by: Andrii Perenesenko <andrii.perenesenko@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #369
Signed-off-by: Alexander Matyushentsev AMatyushentsev@gmail.com
PR adds notifications support to the Rollout. Following changes are implemented: