Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make function call consistent with otherRSs definition #1171

Merged
merged 1 commit into from
Jun 2, 2021

Conversation

huikang
Copy link
Member

@huikang huikang commented May 13, 2021

Signed-off-by: Hui Kang hui.kang@salesforce.com

Signed-off-by: Hui Kang <hui.kang@salesforce.com>
@sonarcloud
Copy link

sonarcloud bot commented May 13, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
15.9% 15.9% Duplication

@codecov
Copy link

codecov bot commented May 13, 2021

Codecov Report

Merging #1171 (bb4cd6a) into master (125c9d9) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1171      +/-   ##
==========================================
- Coverage   81.22%   81.21%   -0.02%     
==========================================
  Files         105      105              
  Lines        9493     9495       +2     
==========================================
  Hits         7711     7711              
- Misses       1268     1269       +1     
- Partials      514      515       +1     
Impacted Files Coverage Δ
rollout/controller.go 75.98% <100.00%> (ø)
rollout/trafficrouting/istio/istio.go 78.92% <0.00%> (-0.66%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 125c9d9...bb4cd6a. Read the comment docs.

@jessesuen jessesuen changed the title fix: make funcioin call consistent with otherRSs definition fix: make function call consistent with otherRSs definition Jun 2, 2021
@jessesuen jessesuen merged commit 3932653 into argoproj:master Jun 2, 2021
caoyang001 pushed a commit to caoyang001/argo-rollouts that referenced this pull request Jun 12, 2021
…#1171)

Signed-off-by: Hui Kang <hui.kang@salesforce.com>
Signed-off-by: caoyang001 <caoyang001@foxmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants