Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Create RolloutPaused condition #1054

Merged
merged 6 commits into from
Apr 8, 2021

Conversation

khhirani
Copy link
Contributor

Closes #352

Signed-off-by: khhirani <kareena.hirani@gmail.com>
Signed-off-by: khhirani <kareena.hirani@gmail.com>
@khhirani khhirani requested a review from jessesuen April 1, 2021 08:17
@codecov
Copy link

codecov bot commented Apr 1, 2021

Codecov Report

Merging #1054 (734272e) into master (e803db0) will increase coverage by 0.11%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1054      +/-   ##
==========================================
+ Coverage   80.90%   81.02%   +0.11%     
==========================================
  Files         103      103              
  Lines        9104     9174      +70     
==========================================
+ Hits         7366     7433      +67     
- Misses       1244     1246       +2     
- Partials      494      495       +1     
Impacted Files Coverage Δ
rollout/sync.go 72.37% <100.00%> (+0.55%) ⬆️
utils/unstructured/unstructured.go 56.52% <0.00%> (-1.26%) ⬇️
metricproviders/newrelic/newrelic.go 92.00% <0.00%> (+0.69%) ⬆️
rollout/pause.go 95.09% <0.00%> (+1.48%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e803db0...734272e. Read the comment docs.

Copy link
Member

@jessesuen jessesuen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see any new unit tests which test this new feature.

Can we also have an e2e test that uses kubectl wait to verify it end-to-end?

@khhirani
Copy link
Contributor Author

khhirani commented Apr 2, 2021

@jessesuen Do we need new unit tests for this feature? I thought the change was sufficiently covered by the existing tests after I modified them, but I can add new ones if you think we need them.

Signed-off-by: khhirani <kareena.hirani@gmail.com>
@sonarcloud
Copy link

sonarcloud bot commented Apr 6, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
23.7% 23.7% Duplication

@khhirani khhirani requested a review from jessesuen April 7, 2021 05:19
@khhirani khhirani merged commit 959a4a5 into argoproj:master Apr 8, 2021
@khhirani khhirani deleted the add-ro-pause-cond branch April 8, 2021 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add conditions to allow to wait for rollout pauses & completions
2 participants