Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

documentation - Rollout spec for bluegreen strategy missing previewMetadata and activeMetadata example fields #1845

Open
zswanson opened this issue Feb 4, 2022 · 10 comments
Assignees
Labels
bug Something isn't working docs Needs documentation/release notes good first issue Good for newcomers hacktoberfest

Comments

@zswanson
Copy link

zswanson commented Feb 4, 2022

Summary

The bluegreen strategy supports adding ephemeral labels and annotations during the rollout, but Rollout spec documentation page are missing this information. We had overlooked the 'ephemeral metadata' page in the user docs and only found this by accident when we assumed that if canary had the fields that it was likely bluegreen did too. This should be added to https://argoproj.github.io/argo-rollouts/features/specification/

  strategy:
    blueGreen:
      activeService: bluegreen-active
      previewService: bluegreen-preview
      previewMetadata:
        labels:
          version: preview
        annotations:
           myorg/team: v2
      activeMetadata:
        labels:
          version: active
        annotations:
           myorg/team: v1

Message from the maintainers:

Impacted by this bug? Give it a 👍. We prioritize the issues with the most 👍.

@zswanson zswanson added the bug Something isn't working label Feb 4, 2022
@harikrongali harikrongali added the docs Needs documentation/release notes label Feb 4, 2022
@blkperl blkperl added the good first issue Good for newcomers label Feb 23, 2022
@swathienugula
Copy link

/assign

@swathienugula
Copy link

swathienugula commented Mar 15, 2022

I would like to work on this issue. Could you please assign to me? @harikrongali @blkperl

swathienugula added a commit to swathienugula/argo-rollouts that referenced this issue Mar 17, 2022
Updated documentation - Rollout spec for bluegreen strategy missing previewMetadata and activeMetadata example fields argoproj#1845
@AakashRaj20
Copy link

@zswanson
/assign

@swathienugula swathienugula removed their assignment Jun 8, 2022
@swathienugula
Copy link

I do not see an option to assign to you @AakashRaj20

@AakashRaj20
Copy link

I do not see an option to assign to you @AakashRaj20

Can you tell me how can I get this issue assigned to me, I want to try it

@AakashRaj20
Copy link

/assign

@iam-veeramalla
Copy link
Member

@AakashRaj20 to get it assigned, I think you should be a member. Someone should manually assign this to you till then as I just did.

@iam-veeramalla
Copy link
Member

Please let me know if you are still interested in working on this, I can take this up if not :)
@AakashRaj20

@harikrongali harikrongali added this to the v1.4 milestone Oct 20, 2022
@zachaller zachaller removed this from the v1.4 milestone Dec 8, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Feb 7, 2023

This issue is stale because it has been open 60 days with no activity.

@kostis-codefresh
Copy link
Member

Fixed as part of #2833

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working docs Needs documentation/release notes good first issue Good for newcomers hacktoberfest
Projects
None yet
Development

No branches or pull requests

8 participants