fix: analysis with multiple metrics (#1261)

Signed-off-by: hari rongali <hari_rongali@intuit.com>
argoproj · Jun 9, 2021 · 3929fb9 · 3929fb9
1 parent 79739fd
commit 3929fb9
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/controller/metrics/analysis.go b/controller/metrics/analysis.go
@@ -106,6 +106,6 @@ func collectAnalysisTemplate(ch chan<- prometheus.Metric, namespace, name string
 
 	for _, metric := range at.Metrics {
 		metricType := metricproviders.Type(metric)
-		addGauge(MetricAnalysisTemplateMetricInfo, 1, metricType)
+		addGauge(MetricAnalysisTemplateMetricInfo, 1, metricType, metric.Name)
 	}
 }
diff --git a/controller/metrics/analysis_test.go b/controller/metrics/analysis_test.go
@@ -179,8 +179,8 @@ analysis_template_info{name="http-benchmark-test",namespace=""} 1
 analysis_template_info{name="http-benchmark-test",namespace="jesse-test"} 1
 # HELP analysis_template_metric_info Information on metrics in analysis templates.
 # TYPE analysis_template_metric_info gauge
-analysis_template_metric_info{name="http-benchmark-test",namespace="",type="Web"} 1
-analysis_template_metric_info{name="http-benchmark-test",namespace="jesse-test",type="Web"} 1
+analysis_template_metric_info{metric="webmetric",name="http-benchmark-test",namespace="",type="Web"} 1
+analysis_template_metric_info{metric="webmetric",name="http-benchmark-test",namespace="jesse-test",type="Web"} 1
 `
 	registry := prometheus.NewRegistry()
 	at := newFakeAnalysisTemplate(fakeAnalysisTemplate)

diff --git a/controller/metrics/prommetrics.go b/controller/metrics/prommetrics.go
@@ -132,7 +132,7 @@ var (
 	MetricAnalysisTemplateMetricInfo = prometheus.NewDesc(
 		"analysis_template_metric_info",
 		"Information on metrics in analysis templates.",
-		append(namespaceNameLabels, "type"),
+		append(namespaceNameLabels, "type", "metric"),
 		nil,
 	)
 )