Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(argo-cd): Add probes for Dex server >= 2.28.0 #880

Closed
wants to merge 0 commits into from

Conversation

pdrastil
Copy link
Member

Add liveness and readiness probes for Dex server >= 2.28.0. For custom image tags where version cannot be determined are probes disabled by default

@pdrastil pdrastil changed the title feat: Add probes for Dex server >= 2.28.0 feat(argo-cd): Add probes for Dex server >= 2.28.0 Aug 20, 2021
@pdrastil pdrastil closed this Aug 23, 2021
@github-actions github-actions bot added size/XS and removed size/M labels Aug 23, 2021
@mkilchhofer
Copy link
Member

mkilchhofer commented Aug 23, 2021

Hi @pdrastil can we reopen this?

I think we should use a simple solution for this and move all probes config to values.yaml
Something like this:

          {{- if .Values.dex.livenessProbe.enabled }}
          livenessProbe:
            {{- omit .Values.dex.livenessProbe "enabled" | toYaml | nindent 12 }}
          {{- end }}
          {{- if .Values.dex.readinessProbe.enabled }}
          readinessProbe:
            {{- omit .Values.dex.readinessProbe "enabled" | toYaml | nindent 12 }}
          {{- end }}

@pdrastil
Copy link
Member Author

@mkilchhofer Sure I can reopen this with changes you've proposed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants