Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(argo-rollouts): Update manifests for OpenShift support #838

Closed
wants to merge 3 commits into from

Conversation

mbhatip
Copy link

@mbhatip mbhatip commented Jul 19, 2021

Dependent on upstream Argo Rollouts PR: argoproj/argo-rollouts#1301

Signed-off-by: Mehmet Hatip mbhatip@gmail.com

Note on DCO:

If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.

Checklist:

  • I have bumped the chart version according to versioning
  • I have updated the chart changelog with all the changes that come with this pull request according to changelog.
  • Any new values are backwards compatible and/or have sensible default.
  • I have signed off all my commits as required by DCO.
  • My build is green (troubleshooting builds).

Changes are automatically published when merged to master. They are not published on branches.

Signed-off-by: Mehmet Hatip <mbhatip@gmail.com>
@mbhatip mbhatip changed the title Extend manifests for OpenShift support feat: Extend manifests for OpenShift support Jul 19, 2021
@mbhatip mbhatip changed the title feat: Extend manifests for OpenShift support feat: Update manifests for OpenShift support Jul 19, 2021
@mbhatip mbhatip changed the title feat: Update manifests for OpenShift support chore: Update manifests for OpenShift support Jul 19, 2021
@mkilchhofer mkilchhofer changed the title chore: Update manifests for OpenShift support feat(argo-rollouts): Update manifests for OpenShift support Jul 26, 2021
@mkilchhofer
Copy link
Member

mkilchhofer commented Jul 26, 2021

Thank you for this contribution. 🙏
What about surrounding the openshift specific RBAC with {{- if .Values.openshift.enabled }} like it's implemented in the argo-cd chart?

Copy link
Member

@mkilchhofer mkilchhofer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Chart version bump and Update changelog annotation needed

Signed-off-by: Marco Kilchhofer <marco@kilchhofer.info>
@mbhatip
Copy link
Author

mbhatip commented Jul 28, 2021

Thank you for this contribution. 🙏
What about surrounding the openshift specific RBAC with {{- if .Values.openshift.enabled }} like it's implemented in the argo-cd chart?

The cluster roles account for all traffic managers, since the Argo Rollouts controller should be able to use any one of them, and it is up to the user who deploys an application with Argo Rollouts to choose which traffic manager to use in the rollout CRD.

@github-actions
Copy link

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot closed this Oct 4, 2021
@mkilchhofer mkilchhofer added the awaiting-upstream Is waiting for a change upstream to be completed before it can be merged. label Oct 4, 2021
@mkilchhofer mkilchhofer reopened this Oct 4, 2021
@github-actions github-actions bot closed this Oct 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
argo-rollouts awaiting-upstream Is waiting for a change upstream to be completed before it can be merged. no-pr-activity size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants