-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(argo-rollouts): Update manifests for OpenShift support #838
Conversation
Signed-off-by: Mehmet Hatip <mbhatip@gmail.com>
Thank you for this contribution. 🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Chart version bump and Update changelog annotation needed
Signed-off-by: Marco Kilchhofer <marco@kilchhofer.info>
The cluster roles account for all traffic managers, since the Argo Rollouts controller should be able to use any one of them, and it is up to the user who deploys an application with Argo Rollouts to choose which traffic manager to use in the rollout CRD. |
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Dependent on upstream Argo Rollouts PR: argoproj/argo-rollouts#1301
Signed-off-by: Mehmet Hatip mbhatip@gmail.com
Note on DCO:
If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.
Checklist:
Changes are automatically published when merged to
master
. They are not published on branches.