Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

configurable casbin file #388

Closed
wants to merge 2 commits into from

Conversation

ragarcia26
Copy link

Checklist:

  • I have update the chart version in Chart.yaml following Semantic Versioning.
  • Any new values are backwards compatible and/or have sensible default.
  • I have followed the testing instructions in the contributing guide.
  • I have signed the CLA and the build is green.
  • I will test my changes again once merged to master and published.

Changes are automatically published when merged to master. They are not published on branches.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Ricardo Garcia seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@ragarcia26
Copy link
Author

I believe this needs the updated argo-cd image to be used with the updated casbin configuration. That has not been completed/merged

@spencergilbert
Copy link
Contributor

Looks like we should leave this in WIP until argocd has implemented custom casbin support?

@seanson seanson added argo-cd enhancement New feature or request awaiting-upstream Is waiting for a change upstream to be completed before it can be merged. labels Jul 14, 2020
@seanson
Copy link
Contributor

seanson commented Oct 16, 2020

I don't currently see any progress in the above ticket about casbin support, are we still expecting upstream support here?

@alexec
Copy link
Contributor

alexec commented Jan 21, 2021

Stale.

@alexec alexec closed this Jan 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
argo-cd awaiting-upstream Is waiting for a change upstream to be completed before it can be merged. enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants