Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(argo-events): resources and tolerations for Argo-Events chart #321

Closed
wants to merge 5 commits into from

Conversation

nirlo
Copy link

@nirlo nirlo commented Apr 24, 2020

Adding resources, tolerations, and affinity to the controller deployments for argo-events.

If there are no nodes without a taint, the deployment will fail. We've become strict on taints with our nodes to ensure that workloads don't leak and that nodes are not accidentally overcommitted. Defaults will be nothing.

Checklist:

  • I have update the chart version in Chart.yaml following Semantic Versioning.
  • Any new values are backwards compatible and/or have sensible default.
  • I have followed the testing instructions in the contributing guide.
  • I have signed the CLA and the build is green.
  • I will test my changes again once merged to master and published.

Changes are automatically published when merged to master. They are not published on branches.

@nirlo nirlo requested a review from jbehling as a code owner April 24, 2020 14:14
@nirlo nirlo changed the title resources, tolerations Fix: resources and tolerations for Argo-Events chart Apr 24, 2020
@nirlo nirlo changed the title Fix: resources and tolerations for Argo-Events chart fix: resources and tolerations for Argo-Events chart Apr 24, 2020
@seanson seanson added argo-events bug Something isn't working labels Apr 27, 2020
@alexec alexec changed the title fix: resources and tolerations for Argo-Events chart fix(argo-events): resources and tolerations for Argo-Events chart Jan 21, 2021
@alexec
Copy link
Contributor

alexec commented Jan 21, 2021

Stale.

@alexec alexec closed this Jan 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
argo-events bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants