Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(argo-cd): Update public.ecr.aws/bitnami/redis-exporter Docker tag to v1.67.0 #3104

Merged
merged 2 commits into from
Jan 28, 2025

Conversation

argoproj-renovate[bot]
Copy link
Contributor

@argoproj-renovate argoproj-renovate bot commented Jan 4, 2025

This PR contains the following updates:

Package Update Change
public.ecr.aws/bitnami/redis-exporter (source) minor 1.58.0 -> 1.67.0

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

@yu-croco
Copy link
Collaborator

yu-croco commented Jan 4, 2025

#3072 made this PR. It seems that we needed to enhance https://github.com/argoproj/argo-helm/blob/main/renovate.json at the same time. 🙃

@argoproj-renovate argoproj-renovate bot force-pushed the renovate/public.ecr.aws-bitnami-redis-exporter-1.x branch 2 times, most recently from 59f524e to 0e67360 Compare January 5, 2025 07:14
@argoproj-renovate argoproj-renovate bot changed the title chore(deps): update public.ecr.aws/bitnami/redis-exporter docker tag to v1.67.0 chore(bitnami/redis-exporter): Update public.ecr.aws/bitnami/redis-exporter Docker tag to v1.67.0 Jan 5, 2025
@yu-croco
Copy link
Collaborator

yu-croco commented Jan 5, 2025

🫠

@tico24
Copy link
Member

tico24 commented Jan 5, 2025

Bitnami’s charts went oci-only about a month ago. Did we update to reflect that? If not, this would explain the error.

@yu-croco
Copy link
Collaborator

yu-croco commented Jan 5, 2025

There was a PR to run Renovate against tags in values.yaml and we needed to handle scripts for it.

But here is the result. 🫠
Need to modify scripts for tags in values.yaml (or stop supporting Renovate to tags in values.yaml).

@tico24
Copy link
Member

tico24 commented Jan 5, 2025

It looks like https://github.com/argoproj/argo-helm/blob/main/scripts/renovate-bump-version.sh Is only designed to look at our internal charts, not third party dependencies. It looks like renovate it running this script expecting to be able to change the upstream chart.yaml.

@tico24
Copy link
Member

tico24 commented Jan 5, 2025

The script needs to be refactored so that it understands that it’s changing our argocd values file and not the third party chart.

@tico24
Copy link
Member

tico24 commented Jan 5, 2025

The issue lies in the depname variable and how it’s then used.

@yu-croco
Copy link
Collaborator

yu-croco commented Jan 5, 2025

I will fix the script in #3106 🙋

@mkilchhofer
Copy link
Member

mkilchhofer commented Jan 5, 2025

The initial PR (#3072) about dependencies inside values.yaml introduced a new PR naming pattern.

Our idea was to name PRs according to conventional commits using the chart names as the scopes:

  • feat(argo-cd): Bump Argo CD
  • chore(argo-cd): Bump redis-exporter
  • chore(argo-workflows): Blah blah

Now we have the dependency in the conventional commit scope. I think we should address this as well.

Ref in contributors guide:
https://github.com/argoproj/argo-helm/blob/main/CONTRIBUTING.md#pull-request-title-linting

@argoproj-renovate argoproj-renovate bot force-pushed the renovate/public.ecr.aws-bitnami-redis-exporter-1.x branch 7 times, most recently from c3ac910 to 12c3e29 Compare January 11, 2025 11:12
@argoproj-renovate argoproj-renovate bot force-pushed the renovate/public.ecr.aws-bitnami-redis-exporter-1.x branch 3 times, most recently from 3628958 to b2a141e Compare January 20, 2025 08:21
@argoproj-renovate argoproj-renovate bot force-pushed the renovate/public.ecr.aws-bitnami-redis-exporter-1.x branch 5 times, most recently from 3521157 to 85c788c Compare January 27, 2025 16:20
…ag to v1.67.0

Signed-off-by: argoproj-renovate[bot] <161757507+argoproj-renovate[bot]@users.noreply.github.com>
@argoproj-renovate argoproj-renovate bot force-pushed the renovate/public.ecr.aws-bitnami-redis-exporter-1.x branch from 85c788c to 0e4d7a9 Compare January 28, 2025 06:22
@argoproj-renovate argoproj-renovate bot changed the title chore(bitnami/redis-exporter): Update public.ecr.aws/bitnami/redis-exporter Docker tag to v1.67.0 chore(argo-cd): Update public.ecr.aws/bitnami/redis-exporter Docker tag to v1.67.0 Jan 28, 2025
@github-actions github-actions bot added size/S and removed size/XS labels Jan 28, 2025
mkilchhofer
mkilchhofer previously approved these changes Jan 28, 2025
…er-1.x

Signed-off-by: Marco Maurer (-Kilchhofer) <mkilchhofer@users.noreply.github.com>
@yu-croco yu-croco merged commit d75b9d3 into main Jan 28, 2025
6 checks passed
@yu-croco yu-croco deleted the renovate/public.ecr.aws-bitnami-redis-exporter-1.x branch January 28, 2025 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants