fix(argo-rollouts): Change type of trafficRouterPlugins and trafficRouterPlugins as list #3036
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The change I made here argoproj#3014 broken the examples. This works w/ my original change: ``` controller: trafficRouterPlugins: - name: "argoproj-labs/gatewayAPI" location: "https://github.com/argoproj-labs/rollouts-plugin-trafficrouter-gatewayapi/releases/download/v0.4.0/gatewayapi-plugin-linux-arm64" sha256: "07e2fe515c900899c96777aac0ab490437a3d62c8adb94512ccb8b859325eb11" ``` But the example shows stringification is needed. I feel having it "look like a real thing instead of a string" is more user friendly. Signed-off-by: Robert Macaulay <robert.macaulay@gmail.com>
6 tasks
taer
changed the title
Signed-off-by: Robert Macaulay <robert.macaulay@gmail.com>
|
My prior change was basically a breaking one. I assumed that no one was using the values.yaml for plugins since it wasn't rendering according to the docs. But that ship sailed, and oops. I will renumber this build to be a non-patch change... It's just docs, but follows up to the actual breaking change for anyone who worked around the initial issue. |
Signed-off-by: Robert Macaulay <robert.macaulay@gmail.com>
|
If y'all are ok w/ this, we should delete 2.37.8 since it was in fact a breaking change.. Thanks @michel-gleeson |
yu-croco
reviewed
Nov 15, 2024
yu-croco
reviewed
Nov 15, 2024
Signed-off-by: Robert Macaulay <robert.macaulay@gmail.com>
Signed-off-by: Robert Macaulay <robert.macaulay@gmail.com>
yu-croco
changed the title
yu-croco
reviewed
Nov 21, 2024
| @@ -19,4 +19,4 @@ annotations: | |||
| url: https://argoproj.github.io/argo-helm/pgp_keys.asc | |||
| artifacthub.io/changes: | | |||
| - kind: fixed | |||
| description: Fixed rendering of plugins in the ConfigMap | |||
| description: Updated plugin values.yaml example and it's implementation to not need to include the stringification or the plugins block that it used to | |||
There was a problem hiding this comment.
As a result, maybe Type of trafficRouterPlugins and trafficRouterPlugins is changed from object to list is enough ?
yu-croco
approved these changes
Nov 21, 2024
jmeridth
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The change I made here #3014 broken the examples.
This works w/ my original change:
But the example shows stringification is needed.
I feel having it "look like a real thing instead of a string" is more user friendly.
Checklist: