feat(argo-cd): Add shareProcessNamespace option to repoServer #291
+6
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k
force-pushed
the
share-process-namespace
branch
from
4ac3248 to
507e46d
Compare
|
@k can you tell me a little more about the use case here? I'm not super familiar with that spec, but it seems like it would only be useful if you're running multiple containers in the repo-server pod. Are you using something like an istio-sidecar and running into problems? |
seanson
suggested changes
Apr 21, 2020
Comment on lines
+42
to
+44
| {{- if .Values.repoServer.shareProcessNamespace }} | ||
| shareProcessNamespace: true | ||
| {{- end }} |
There was a problem hiding this comment.
Please change the invocation of the template to with so it's easier to template and future proof.
Suggested change
| {{- if .Values.repoServer.shareProcessNamespace }} | |
| shareProcessNamespace: true | |
| {{- end }} | |
| {{- with .Values.repoServer.shareProcessNamespace }} | |
| shareProcessNamespace: {{ . }} | |
| {{- end }} |
alexec
changed the title
|
Stale. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
Chart.yamlfollowing Semantic Versioning.Changes are automatically published when merged to
master. They are not published on branches.