Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(argocd-image-updater): adding google artifact registry to the list #2349

Closed
wants to merge 47 commits into from
Closed

docs(argocd-image-updater): adding google artifact registry to the list #2349

wants to merge 47 commits into from

Conversation

Kripu77
Copy link
Contributor

@Kripu77 Kripu77 commented Nov 16, 2023

Checklist:

  • I have bumped the chart version according to versioning
  • I have updated the documentation according to documentation
  • I have updated the chart changelog with all the changes that come with this pull request according to changelog.
  • Any new values are backwards compatible and/or have sensible default.
  • I have signed off all my commits as required by DCO.
  • My build is green (troubleshooting builds).

Kripu77 and others added 25 commits November 16, 2023 16:38
@Kripu77
typo fix
c64c208 
Signed-off-by: Kripu Khadka <khadkakripu4@gmail.com>
@Kripu77
Revert "typo fix"
a450f0d 
This reverts commit b02b2fb.

Signed-off-by: Kripu Khadka <khadkakripu4@gmail.com>
@yu-croco @Kripu77
fix(argo-cd): Align redis-ha's affinity type to upstream due to warni…
fb06c49 
…ngs (argoproj#2270)

Signed-off-by: yu-croco <yu.croco@gmail.com>
Signed-off-by: Kripu Khadka <khadkakripu4@gmail.com>
@dependabot @Kripu77
chore(deps): bump docker/login-action from 2.2.0 to 3.0.0 (argoproj#2271
c0b4148 
)

Signed-off-by: Kripu Khadka <khadkakripu4@gmail.com>
@ma-ts @Kripu77
fix(argo-cd): make ServiceMonitor annotations in ArgoCD server condit…
98a53b0 
…ional (argoproj#2273)

* fix: add argocd servicemonitor annotations conditionally
Signed-off-by: Mats Willemsen <mats.willemsen@ah.nl>

* chore(argo-cd): add changelog

Signed-off-by: Mats Willemsen <mats.willemsen@ah.nl>

---------

Signed-off-by: Mats Willemsen <mats.willemsen@ah.nl>
Signed-off-by: Kripu Khadka <khadkakripu4@gmail.com>
@sibucan @Kripu77
fix(argo-cd): Add checksum for CMP ConfigMap in repo-server Pod annot…
4606d48 
…ations (argoproj#2275)

Add checksum for CMP ConfigMap in repo-server

This helm chart defines the plugins as ConfigMaps -- according to the docs, when the CM is modified, the repo-server Pod must be restarted to have the sidecars pick up the latest changes:

https://argo-cd.readthedocs.io/en/stable/operator-manual/config-management-plugins/#debugging-a-cmp

The changes in this helm chart allow for a checksum to be calculated from the ConfigMap and added as a Pod annotation so whenever the CM values are modified, the Pod is restarted automatically.

Signed-off-by: sibucan <luis.ramirez.rivera92@gmail.com>
Signed-off-by: Kripu Khadka <khadkakripu4@gmail.com>
@Pionerd @Kripu77
fix(argo-cd): Redis to 7.0.13 to fix CVE-2022-48174 (argoproj#2279)
f08b279 
* Redis to 7.0.13

Signed-off-by: Pieter van der Giessen <pieter@pionative.com>

* changelog

Signed-off-by: Pieter van der Giessen <pieter@pionative.com>

---------

Signed-off-by: Pieter van der Giessen <pieter@pionative.com>
Signed-off-by: Kripu Khadka <khadkakripu4@gmail.com>
@dependabot @Kripu77
chore(deps): bump actions/checkout from 4.0.0 to 4.1.0 (argoproj#2280)
dc48e69 
Bumps [actions/checkout](https://github.com/actions/checkout) from 4.0.0 to 4.1.0.
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](actions/checkout@3df4ab1...8ade135)

---
updated-dependencies:
- dependency-name: actions/checkout
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Kripu Khadka <khadkakripu4@gmail.com>
@dependabot @Kripu77
chore(deps): bump amannn/action-semantic-pull-request from 5.2.0 to 5…
385765d 
….3.0 (argoproj#2284)

Signed-off-by: Kripu Khadka <khadkakripu4@gmail.com>
@dependabot @Kripu77
chore(deps): bump ossf/scorecard-action from 2.2.0 to 2.3.0 (argoproj…
0a2de51 
…#2290)

Signed-off-by: Kripu Khadka <khadkakripu4@gmail.com>
@dependabot @Kripu77
chore(deps): bump actions/setup-python from 4.7.0 to 4.7.1 (argoproj#…
f0e0b97 
…2289)

Signed-off-by: Kripu Khadka <khadkakripu4@gmail.com>
@mkilchhofer @Kripu77
fix(argo-cd): Sync redis / redis-ha readOnlyRootFilesystem from upstr…
ff63dc0 
…eam (argoproj#2294)

Signed-off-by: Marco Maurer <mkilchhofer@users.noreply.github.com>
Signed-off-by: Kripu Khadka <khadkakripu4@gmail.com>
@yu-croco @Kripu77
feat(argo-workflows): Configure declarative server auth mode (argopro…
addfba7 
…j#2291)

Signed-off-by: Kripu Khadka <khadkakripu4@gmail.com>
@jmeridth @Kripu77
chore(argo-workflows): Upgrade argo-workflows to 3.5.0 (argoproj#2228)
6582c43 
Diff based on the rc1 branch currently here [3.4.10...3.5.0](argoproj/argo-workflows@v3.4.10...v3.5.0)

Signed-off-by: jmeridth <jmeridth@gmail.com>
Signed-off-by: Kripu Khadka <khadkakripu4@gmail.com>
@kvanzuijlen @Kripu77
feat(argo-workflows): Added commonLabels (argoproj#2300)
c0da75c 
Signed-off-by: Kripu Khadka <khadkakripu4@gmail.com>
@jonwraymond @Kripu77
fix(argo-workflows): add all crds to aggregate-roles template (argopr…
cdb2d81 
…oj#2301)

fix: add all crds to aggregate-roles

Signed-off-by: Jonathan Raymond <jonwraymond@gmail.com>
Signed-off-by: Kripu Khadka <khadkakripu4@gmail.com>
@dependabot @Kripu77
chore(deps): bump actions/checkout from 4.1.0 to 4.1.1 (argoproj#2304)
f60dac2 
Signed-off-by: Kripu Khadka <khadkakripu4@gmail.com>
@yu-croco @Kripu77
chore(argo-workflows): Add sample of PostgreSQL ssl entries in values…
6d9b7fc 
….yaml (argoproj#2307)

Signed-off-by: yu-croco <yu.croco@gmail.com>
Signed-off-by: Kripu Khadka <khadkakripu4@gmail.com>
@evgeniy-khatko @tico24 @Kripu77
feat(argo-workflows): Updated supported workers parameters (argoproj#…
723a544 
…2297)

* feat(argo-workflows): Updated supported workers parameters

Change
------
Based on argo-workflows [scaling documents](https://argoproj.github.io/argo-workflows/scaling/)
it's possible to set following workers values: `--workflow-workers`, `--workflow-ttl-workers`, `--pod-cleanup-workers`
and statring 3.5 `--cron-workflow-workers`. This change allows chart
consumers to take advatage of _all_ these parameters.

Testing
-------
```
helm upgrade argowf charts/argo-workflows -n argo --values charts/argo-workflows/values.yaml --create-namespace --debug | grep -A70 "Source: argo-workflows/templates/controller/workflow-controller-deployment.yaml" | grep workers

helm upgrade argowf charts/argo-workflows -n argo --values charts/argo-workflows/values.yaml --create-namespace --debug | grep -A70 "Source: argo-workflows/templates/controller/workflow-controller-deployment.yaml" | grep -A1 workers
          - "--workflow-workers"
          - "10"

helm upgrade argowf charts/argo-workflows -n argo --values charts/argo-workflows/values.yaml --create-namespace --debug | grep -A70 "Source: argo-workflows/templates/controller/workflow-controller-deployment.yaml" | grep -A1 workers
          - "--workflow-workers"
          - "10"
          - "--workflow-ttl-workers"
          - "20"

helm upgrade argowf charts/argo-workflows -n argo --values charts/argo-workflows/values.yaml --create-namespace --debug | grep -A70 "Source: argo-workflows/templates/controller/workflow-controller-deployment.yaml" | grep -A1 workers
          - "--workflow-workers"
          - "10"
          - "--workflow-ttl-workers"
          - "20"
          - "--pod-cleanup-workers"
          - "30"

helm upgrade argowf charts/argo-workflows -n argo --values charts/argo-workflows/values.yaml --create-namespace --debug | grep -A70 "Source: argo-workflows/templates/controller/workflow-controller-deployment.yaml" | grep -A1 workers
          - "--workflow-workers"
          - "10"
          - "--workflow-ttl-workers"
          - "20"
          - "--pod-cleanup-workers"
          - "30"
          - "--cron-workflow-workers"
          - "40"
```

Signed-off-by: Evgeny Khatko <owen.tko@gmail.com>
Signed-off-by: Evgeny Khatko <ekhatko@paypal.com>

* Addressing PR feedback.

Signed-off-by: Evgeny Khatko <ekhatko@paypal.com>

* newline

Signed-off-by: Tim Collins <45351296+tico24@users.noreply.github.com>

* Update Chart.yaml

Signed-off-by: Tim Collins <45351296+tico24@users.noreply.github.com>

* Update Chart.yaml

Signed-off-by: Tim Collins <45351296+tico24@users.noreply.github.com>

---------

Signed-off-by: Evgeny Khatko <owen.tko@gmail.com>
Signed-off-by: Evgeny Khatko <ekhatko@paypal.com>
Signed-off-by: Tim Collins <45351296+tico24@users.noreply.github.com>
Co-authored-by: Evgeny Khatko <ekhatko@paypal.com>
Co-authored-by: Tim Collins <45351296+tico24@users.noreply.github.com>
Signed-off-by: Kripu Khadka <khadkakripu4@gmail.com>
@jmeridth @Kripu77
fix(argo-rollouts): controller replicas count comparison (argoproj#2309)
985b197 
Signed-off-by: Kripu Khadka <khadkakripu4@gmail.com>
@toyamagu-2021 @Kripu77
feat(argo-cd): add terminationGracePeriodSeconds (argoproj#2310)
68b8034 
Signed-off-by: toyamagu-2021 <toyamagu2021@gmail.com>
Signed-off-by: Kripu Khadka <khadkakripu4@gmail.com>
@yu-croco @Kripu77
chore(argo-cd): Upgrade Argo CD to v2.8.5 (argoproj#2313)
78e1053 
Signed-off-by: Kripu Khadka <khadkakripu4@gmail.com>
@dependabot @Kripu77
chore(deps): bump ossf/scorecard-action from 2.3.0 to 2.3.1 (argoproj…
b781db6 
…#2314)

Signed-off-by: Kripu Khadka <khadkakripu4@gmail.com>
@pdrastil @Kripu77
fix(argo-cd): Update Bitbucket SSH key (argoproj#2317)
24eba31 
Signed-off-by: Petr Drastil <petr.drastil@gmail.com>
Signed-off-by: Kripu Khadka <khadkakripu4@gmail.com>
@DrFaust92 @Kripu77
feat(argo-cd): add notification cluster role (argoproj#2315)
2ecded7 
* Add notification cluster role

Signed-off-by: drfaust92 <ilia.lazebnik@gmail.com>

* Add notification cluster role

Signed-off-by: drfaust92 <ilia.lazebnik@gmail.com>

* Add notification cluster role

Signed-off-by: drfaust92 <ilia.lazebnik@gmail.com>

* Add notification cluster role

Signed-off-by: drfaust92 <ilia.lazebnik@gmail.com>

---------

Signed-off-by: drfaust92 <ilia.lazebnik@gmail.com>
Signed-off-by: Kripu Khadka <khadkakripu4@gmail.com>
yu-croco and others added 7 commits November 16, 2023 16:38
@yu-croco @Kripu77
chore(argo-cd): Upgrade Argo CD to v2.9.1 (argoproj#2344)
4c288d6 
Signed-off-by: Kripu Khadka <khadkakripu4@gmail.com>
@DrFaust92 @yu-croco @Kripu77
chore(argo-rollouts): Bump rollouts to 1.6.1 (argoproj#2345)
c1efdd9 
* Bump rollouts to 1.6.2

Signed-off-by: drfaust92 <ilia.lazebnik@gmail.com>

* Bump to 1.6.1

Signed-off-by: drfaust92 <ilia.lazebnik@gmail.com>

* Bump to 1.6.1

Signed-off-by: drfaust92 <ilia.lazebnik@gmail.com>

---------

Signed-off-by: drfaust92 <ilia.lazebnik@gmail.com>
Co-authored-by: Aikawa <yu.croco@gmail.com>
Signed-off-by: Kripu Khadka <khadkakripu4@gmail.com>
@DrFaust92 @Kripu77
chore(argo-rollouts): Bump rollouts to 1.6.2 (argoproj#2347)
1397a0c 
Signed-off-by: Kripu Khadka <khadkakripu4@gmail.com>
@bodgit @Kripu77
fix(argo-workflows): Add parameters for tuning revisionHistoryLimit a…
8391047 
…nd emptyDir volumes (argoproj#2346)

Signed-off-by: Kripu Khadka <khadkakripu4@gmail.com>
@yu-croco @Kripu77
fix(argo-workflows): Align version label (argoproj#2342)
69ff5fc 
* fix(argo-workflows): Aligne version label

Signed-off-by: yu-croco <yu.croco@gmail.com>

* fix(argo-workflows): fix typo

Signed-off-by: yu-croco <yu.croco@gmail.com>

---------

Signed-off-by: yu-croco <yu.croco@gmail.com>
Signed-off-by: Kripu Khadka <khadkakripu4@gmail.com>
@Kripu77 @yu-croco
docs(github): typo fix in security.md (argoproj#2343)
a862d12 
* typo fix

Signed-off-by: Kripu Khadka <khadkakripu4@gmail.com>

* Revert "typo fix"

This reverts commit b02b2fb.

Signed-off-by: Kripu Khadka <khadkakripu4@gmail.com>

* typo fix in SECURITY.md

Signed-off-by: Kripu Khadka <84505567+Kripu77@users.noreply.github.com>
Signed-off-by: Kripu Khadka <khadkakripu4@gmail.com>

---------

Signed-off-by: Kripu Khadka <khadkakripu4@gmail.com>
Signed-off-by: Kripu Khadka <84505567+Kripu77@users.noreply.github.com>
Co-authored-by: Aikawa <yu.croco@gmail.com>
Signed-off-by: Kripu Khadka <khadkakripu4@gmail.com>
@Kripu77
Adding Google artifact repository to the list
b8b548d 
Signed-off-by: Kripu Khadka <khadkakripu4@gmail.com>
@Kripu77 Kripu77 force-pushed the add-artifact-repo-to-image-updater branch from 735b30f to b8b548d Compare November 16, 2023 10:53
@yu-croco
Copy link
Collaborator

Hi @Kripu77 , it looks that this PR has a lot of unnecessary diffs. 👀

@tico24
Copy link
Member

tico24 commented Nov 16, 2023

Main branch just needed to be merged in. It looks much less horrifying now!

@tico24
Copy link
Member

tico24 commented Nov 16, 2023

The latest version of the referenced documentation does not mention Google Artifcact Registry though: https://argocd-image-updater.readthedocs.io/en/latest/configuration/registries/

@yu-croco
Copy link
Collaborator

Hi @Kripu77 , can you give us the official info that argocd-image-updater supports Google Artifact Registry ?

The latest version of the referenced documentation does not mention Google Artifcact Registry though: https://argocd-image-updater.readthedocs.io/en/latest/configuration/registries/

@github-actions GitHub Actions
Copy link

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot closed this Jan 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkilchhofer mkilchhofer Awaiting requested review from mkilchhofer mkilchhofer is a code owner

@jmeridth jmeridth Awaiting requested review from jmeridth jmeridth is a code owner

@yu-croco yu-croco Awaiting requested review from yu-croco yu-croco is a code owner

@mbevc1 mbevc1 Awaiting requested review from mbevc1

@pdrastil pdrastil Awaiting requested review from pdrastil

@tico24 tico24 Awaiting requested review from tico24

@vladlosev vladlosev Awaiting requested review from vladlosev

Assignees
No one assigned
Labels
argocd-image-updater no-pr-activity size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.