Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(argo-cd): Support new k8sclient.retry options #2348

Closed
wants to merge 1 commit into from
Closed

feat(argo-cd): Support new k8sclient.retry options #2348

wants to merge 1 commit into from

Conversation

llavaud
Copy link
Contributor

@llavaud llavaud commented Nov 15, 2023 •
edited
Loading

add support for the new following controller/server parameters introduce in the 2.9.0 (argoproj/argo-cd#16154) version:

  • controller.k8sclient.retry.max
  • controller.k8sclient.retry.base.backoff
  • server.k8sclient.retry.max
  • server.k8sclient.retry.base.backoff

Checklist:

  • I have bumped the chart version according to versioning
  • I have updated the documentation according to documentation
  • I have updated the chart changelog with all the changes that come with this pull request according to changelog.
  • Any new values are backwards compatible and/or have sensible default.
  • I have signed off all my commits as required by DCO.
  • My build is green (troubleshooting builds).

@llavaud
feat(argocd): Support new k8sclient.retry options
8adb216 
add support for the new following controller/server parameters
introduce in the 2.9.0 version:
- controller.k8sclient.retry.max
- controller.k8sclient.retry.base.backoff
- server.k8sclient.retry.max
- server.k8sclient.retry.base.backoff

Signed-off-by: Laurent Lavaud <llavaud@lvdconsulting.pro>
@llavaud llavaud changed the title feat(argocd): Support new k8sclient.retry options feat(argo-cd): Support new k8sclient.retry options Nov 15, 2023
@tico24
Copy link
Member

tico24 commented Nov 15, 2023

Your PR LGTM. Not that I don't believe you, but I can't see the retries stuff actually in v2.9.0 - this is almost certainly because I can't use computers but are you able to reference it for me?

@llavaud
Copy link
Contributor Author

llavaud commented Nov 15, 2023

Your PR LGTM. Not that I don't believe you, but I can't see the retries stuff actually in v2.9.0 - this is almost certainly because I can't use computers but are you able to reference it for me?

Here is the related PR: argoproj/argo-cd#16154

@tico24
Copy link
Member

tico24 commented Nov 15, 2023

I see the PR. I couldn't see it merged/released to v2.9.x - it seems to be sat on master.

@llavaud
Copy link
Contributor Author

llavaud commented Nov 15, 2023

I see the PR. I couldn't see it merged/released to v2.9.x - it seems to be sat on master.

It is in the CHANGELOG, weird...

@tico24
Copy link
Member

tico24 commented Nov 15, 2023

I told you I couldn't use computers :)

Cheers for your help.

@llavaud
Copy link
Contributor Author

llavaud commented Nov 15, 2023 •
edited
Loading

I told you I couldn't use computers :)

Cheers for your help.

no, you're right, code is not in the 2.9.0 compared to master :(

@mbevc1
Copy link
Collaborator

mbevc1 commented Nov 15, 2023

Do we want to defer this until upstream releases this? 🤔

@tico24
Copy link
Member

tico24 commented Nov 15, 2023

Do we want to defer this until upstream releases this? 🤔

This would be my personal preference.

@jmeridth jmeridth added the awaiting-upstream Is waiting for a change upstream to be completed before it can be merged. label Nov 15, 2023
@jmeridth jmeridth requested a review from tico24 November 15, 2023 15:03
@mkilchhofer mkilchhofer added the on-hold Issues or Pull Requests with this label will never be considered stale label Nov 17, 2023
@pdrastil
Copy link
Member

pdrastil commented Feb 6, 2024

Closed as part of 2.10.0 upgrade in #2476

@pdrastil pdrastil closed this Feb 6, 2024
@llavaud llavaud deleted the argocd-k8sclient-retry branch February 7, 2024 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbevc1 mbevc1 Awaiting requested review from mbevc1 mbevc1 is a code owner

@mkilchhofer mkilchhofer Awaiting requested review from mkilchhofer mkilchhofer is a code owner

@yu-croco yu-croco Awaiting requested review from yu-croco yu-croco is a code owner

@jmeridth jmeridth Awaiting requested review from jmeridth jmeridth is a code owner

@pdrastil pdrastil Awaiting requested review from pdrastil pdrastil is a code owner

@tico24 tico24 Awaiting requested review from tico24 tico24 is a code owner

Assignees
No one assigned
Labels
argo-cd awaiting-upstream Is waiting for a change upstream to be completed before it can be merged. on-hold Issues or Pull Requests with this label will never be considered stale size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@llavaud @tico24 @mbevc1 @pdrastil @jmeridth @mkilchhofer