Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(argo-cd): Default applicationSet metrics port to 8085 #2125

Merged
merged 1 commit into from
Jun 21, 2023
Merged

fix(argo-cd): Default applicationSet metrics port to 8085 #2125

merged 1 commit into from
Jun 21, 2023

Conversation

teroahonen-vungle
Copy link
Contributor

@teroahonen-vungle teroahonen-vungle commented Jun 21, 2023 •
edited
Loading

Change applicatiosetSet.conteinerPorts.metrics to 8085 so that it matches applicationSet.metrics.port

Checklist:

  • I have bumped the chart version according to versioning
  • I have updated the documentation according to documentation
  • I have updated the chart changelog with all the changes that come with this pull request according to changelog.
  • Any new values are backwards compatible and/or have sensible default.
  • I have signed off all my commits as required by DCO.
  • My build is green (troubleshooting builds).

@teroahonen-vungle
Change applicationSet controller metrics port to 8085
4f4e8dc 
Signed-off-by: Tero Ahonen <tahonen@liftoff.io>
@tico24 tico24 merged commit b8c29f7 into argoproj:main Jun 21, 2023
@mkilchhofer
Copy link
Member

mkilchhofer commented Jun 23, 2023 •
edited
Loading

Oh sad I see this PR so late. It was wrong to accept this PR, as our chart now differs from the upstream kustomize manifests:
https://github.com/argoproj/argo-cd/blob/v2.7.6/manifests/base/applicationset-controller/argocd-applicationset-controller-deployment.yaml#L27

Filed PR to mitigate this:

@mkilchhofer mkilchhofer mentioned this pull request Jun 23, 2023
Merged
6 tasks
@renovate renovate bot mentioned this pull request Jan 30, 2024
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbevc1 mbevc1 mbevc1 approved these changes

@tico24 tico24 tico24 approved these changes

@mkilchhofer mkilchhofer Awaiting requested review from mkilchhofer mkilchhofer is a code owner

@yu-croco yu-croco Awaiting requested review from yu-croco yu-croco is a code owner

@jmeridth jmeridth Awaiting requested review from jmeridth jmeridth is a code owner

@pdrastil pdrastil Awaiting requested review from pdrastil pdrastil is a code owner

Assignees
No one assigned
Labels
argo-cd size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@teroahonen-vungle @mkilchhofer @mbevc1 @tico24