feat: add kubernetes version tag and set container security capabilities #203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bartse
changed the title
|
@seanson was there a reason the chart didn't have this label before? it does look fairly common in stable charts. |
No reason but there's no real checklist for things to include / best practices so we just add things ad-hoc. |
jdeprin
added a commit
to jdeprin/argo-helm
that referenced
this pull request
Jan 15, 2020
Breaking change introduced in this PR argoproj#203 causes labeles to be removed due to an empty vaule in .Values.*.image.tag.
|
Hi, |
|
Also, you introduced a lot of trailing spaces. |
|
Somehow I missed those default values. There is an open PR for this to fix it 208 |
spencergilbert
pushed a commit
that referenced
this pull request
Jan 15, 2020
* Fixes version label in argocd components Breaking change introduced in this PR #203 causes labeles to be removed due to an empty vaule in .Values.*.image.tag. * Update Chart.yaml patch version bump
nouseforaname
pushed a commit
to nouseforaname/argo-helm
that referenced
this pull request
Jan 29, 2020
nouseforaname
pushed a commit
to nouseforaname/argo-helm
that referenced
this pull request
Jan 29, 2020
* Fixes version label in argocd components Breaking change introduced in this PR argoproj#203 causes labeles to be removed due to an empty vaule in .Values.*.image.tag. * Update Chart.yaml patch version bump
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
Chart.yamlfollowing Semantic Versioning.Changes are automatically published when merged to
master. They are not published on branches.