feat: Add securityContext. Fixes #96 #185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: David J. M. Karlsen <david@davidkarlsen.com>
davidkarlsen
requested review from
seanson and
spencergilbert
as code owners
|
|
davidkarlsen
changed the title
Signed-off-by: David J. M. Karlsen <david@davidkarlsen.com>
seanson
suggested changes
Dec 12, 2019
Signed-off-by: David J. M. Karlsen <david@davidkarlsen.com>
davidkarlsen
force-pushed
the
feature/securitycontext
branch
from
baa60b9 to
59e91a4
Compare
|
@seanson PTAL |
seanson
suggested changes
Dec 15, 2019
charts/argo-cd/templates/argocd-application-controller/deployment.yaml
Outdated
Show resolved
Hide resolved
Signed-off-by: David J. M. Karlsen <david@davidkarlsen.com>
seanson
approved these changes
Dec 16, 2019
nouseforaname
pushed a commit
to nouseforaname/argo-helm
that referenced
this pull request
Jan 29, 2020
* make securityContext optional * add docs * bump chart version Signed-off-by: David J. M. Karlsen <david@davidkarlsen.com>
louisblin
reviewed
Feb 19, 2020
| @@ -25,6 +25,9 @@ spec: | |||
| app.kubernetes.io/component: {{ .Values.redis.name }} | |||
| spec: | |||
| automountServiceAccountToken: false | |||
| {{- if .Values.global.securityContext }} | |||
| securityContext: {{- toYaml .Values.global.securityContext | nindent 8 }} | |||
| {{- end }} | |||
There was a problem hiding this comment.
Hi all,
That PR didn't add a similar entry for templates/dex/deployment.yaml with a global.securityContext. Was that simply an omission that we should fix?
There was a problem hiding this comment.
I guess it was just forgotten - does it work with a similar security-context? I can add a PR.
There was a problem hiding this comment.
Yes, I think so. I've been using the same lines in dex/deployment.yaml as what you had here for redis/deployment.yaml and it's been working fine. Thanks for the PR.
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: David J. M. Karlsen david@davidkarlsen.com
Adds security-context.
I wonder if it makes sense to reuse some other charts for dex / redis to avoid reinventing the wheel for these?
Checklist:
Chart.yamlfollowing Semantic Versioning.Changes are automatically published when merged to
master. They are not published on branches.This change is