feat(argo-cd)!: refactor ingress to support any backend service #1826
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdomag
requested review from
davidkarlsen,
mr-sour,
yann-soubeyrand,
mbevc1,
mkilchhofer,
yu-croco,
jmeridth and
pdrastil
as code owners
Signed-off-by: Jacek Domagalski <domagalski.j@gmail.com>
|
Let me know if you think this is the right direction. If so I would adjust not only argo-cd server but other components of argo-cd and their corresponding values |
pdrastil
reviewed
Feb 18, 2023
| # -- Ingress path type. One of `Exact`, `Prefix` or `ImplementationSpecific` | ||
| pathType: Prefix | ||
| # -- Additional ingress paths | ||
| - path: / |
There was a problem hiding this comment.
This is the same as extraPaths just below that allow following configuration:
extraPaths:
- path: /*
pathType: Prefix
backend:
service:
name: ssl-redirect
port:
name: https
pdrastil
reviewed
Feb 18, 2023
| @@ -29,36 +29,27 @@ spec: | |||
| rules: | |||
| {{- if .Values.server.ingress.hosts }} | |||
| {{- range $host := .Values.server.ingress.hosts }} | |||
| {{- if and $.Values.server.ingressGrpc.isAWSALB $.Values.server.ingressGrpc.enabled }} | |||
| {{ $serviceName = printf "%s-grpc" (include "argo-cd.server.fullname" $) }} | |||
There was a problem hiding this comment.
This will break AWS integration. AWS ALB requires 2 ingress routes (1st for http / https, 2nd for grpc traffic targeting grpc service with ALB annotations)
There was a problem hiding this comment.
I was not aware of this. @pdrastil thanks for review, I will cancel this PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves:
Signed-off-by: Jacek Domagalski domagalski.j@gmail.com
Note on DCO:
If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.
Checklist:
Changes are automatically published when merged to
main. They are not published on branches.