[charts/argo-cd] Update to 1.3, some chart cleanup #165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tested and working, added a sample configuration for additional repositories and an OIDC configuration to the values.yaml |
|
Testted with:
|
|
One thing... Release Version in README.md still 1.0.4 :-) |
This bumps the version of ArgoCD to 1.3 and the chart version to 1.1 due to a CRD change. Restored conditional CRDs to correct #27. Additionally, some value defaults were added so Helm strict linting could pass.
This adds some examples to the values.yaml on how to use the new Helm repo chart types. Add helmignore to help with development.
Removed this as we all keep forgetting it, might look into a more dynamic way to do this. |
|
👍 Confirming it's working |
alexec
approved these changes
Nov 20, 2019
nouseforaname
pushed a commit
to nouseforaname/argo-helm
that referenced
this pull request
Jan 29, 2020
* [charts/argo-cd] Update to 1.3, some chart cleanup * Bumps the version of ArgoCD to 1.3 and the chart version to 1.2 due to a CRD change. Restored conditional CRDs to correct argoproj#27. Additionally, some value defaults were added so Helm strict linting could pass. * This adds some examples to the values.yaml on how to use the new Helm repo chart types. Add helmignore to help with development.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This bumps the version of ArgoCD to 1.3 and the chart version to 1.1 due
to a CRD change. Restored conditional CRDs to correct #27. Additionally,
some value defaults were added so Helm strict linting could pass.
Checklist:
Chart.yamlfollowing Semantic Versioning.Changes are automatically published when merged to
master. They are not published on branches.