feat(argocd-image-updater): Add support for additional initContainers and additional volume/volumeMounts for argocd-image-updater #1542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bakito
changed the title
bakito
changed the title
…eMounts fix github action to handle crd installation correctly Signed-off-by: bakito <github@bakito.ch>
oliverbaehler
approved these changes
Oct 11, 2022
mkilchhofer
reviewed
Oct 12, 2022
| kubectl apply -f charts/argo-cd/templates/crds | ||
| helm repo add dandydeveloper https://dandydeveloper.github.io/charts/ | ||
| helm dependency build charts/argo-cd/ | ||
| helm template charts/argo-cd/ -s templates/crds/* | kubectl apply -f - |
There was a problem hiding this comment.
@bakito why so complicated now? ;-)
There was a problem hiding this comment.
AH lol, answering myself: Because Argo CD have now templated CRDs
There was a problem hiding this comment.
@mkilchhofer
Because the crd need to be rendered since they are in templates.
Crds were moved into templates and extenedt with template logic which prevents them to be applied as is.
See https://github.com/argoproj/argo-helm/blob/main/charts/argo-cd/templates/crds/crd-project.yaml#L6
To get my pr green I had to fix this logic in the action, as it was forgotten to be tested in the original PR.
#1342
I did not find an easier solution, if you have one, feel free to change it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note on DCO:
If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.
Checklist:
Changes are automatically published when merged to
main. They are not published on branches.