chore(github): Update actions' versions #1525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: yu-croco <yu.croco@gmail.com>
yu-croco
commented
Oct 8, 2022
| @@ -18,9 +18,9 @@ jobs: | |||
| uses: azure/setup-helm@v1 | |||
|
|
|||
| - name: Set up python | |||
| uses: actions/setup-python@v3 | |||
| uses: actions/setup-python@v4 | |||
There was a problem hiding this comment.
There is no breaking changes. 👀
https://github.com/actions/setup-python/releases/tag/v4.0.0
yu-croco
commented
Oct 8, 2022
| @@ -55,7 +55,7 @@ jobs: | |||
| fi | |||
|
|
|||
| - name: Create kind cluster | |||
| uses: helm/kind-action@v1.2.0 | |||
| uses: helm/kind-action@v1.4.0 | |||
There was a problem hiding this comment.
There is no breaking changes. 👀
yu-croco
commented
Oct 8, 2022
Comment on lines
+23
to
+26
| uses: azure/setup-helm@v3 | ||
| with: | ||
| version: latest # stable | ||
| token: ${{ secrets.GITHUB_TOKEN }} # only needed if version is 'latest' |
There was a problem hiding this comment.
I set config by referring sample. 👀
https://github.com/Azure/setup-helm#example
Current CI also uses latest Helm version, v3.10.0.
https://github.com/argoproj/argo-helm/actions/runs/3210246553/jobs/5247553641
yu-croco
commented
Oct 8, 2022
| @@ -14,7 +14,7 @@ jobs: | |||
| pull-requests: write # for actions/stale to close stale PRs | |||
| runs-on: ubuntu-latest | |||
| steps: | |||
| - uses: actions/stale@v5 | |||
| - uses: actions/stale@v6 | |||
There was a problem hiding this comment.
This version has breaking change below, but it looks ok for us. 👀
https://github.com/actions/stale/releases/tag/v6.0.0
Issues/PRs default
close-issue-reasonis nownot_planned
yu-croco
changed the title
jmeridth
approved these changes
Oct 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: yu-croco yu.croco@gmail.com
Note on DCO:
If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.
Checklist:
Changes are automatically published when merged to
main. They are not published on branches.