feat(argo-rollouts) Add controller.extraEnv #1333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ability to specify environment variables for rollouts-controller from values.yaml Signed-off-by: Ben Hayden <hayden767@gmail.com>
deybhayden
force-pushed
the
rollouts-extra-env
branch
from
d4e52de to
972d2d6
Compare
Signed-off-by: Marco Kilchhofer <mkilchhofer@users.noreply.github.com>
Signed-off-by: Marco Kilchhofer <mkilchhofer@users.noreply.github.com>
mkilchhofer
approved these changes
Jun 17, 2022
6 tasks
terrych0u
pushed a commit
to terrych0u/argo-helm
that referenced
this pull request
Aug 4, 2022
* feat(argo-rollouts) Add controller.extraEnv Ability to specify environment variables for rollouts-controller from values.yaml Signed-off-by: Ben Hayden <hayden767@gmail.com> * Also implement extraEnv for dashboard component Signed-off-by: Marco Kilchhofer <mkilchhofer@users.noreply.github.com> * Reword changelog line Signed-off-by: Marco Kilchhofer <mkilchhofer@users.noreply.github.com> Co-authored-by: Marco Kilchhofer <mkilchhofer@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ability to specify environment variables for rollouts-controller from values.yaml. Fixes Helm install that lead to this errant bug report.
Note on DCO:
If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.
Checklist:
Changes are automatically published when merged to
main. They are not published on branches.