feat(argo-applicationset): update appVersion to 0.4.1 #1223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Philippe <philippe.burgisser@camptocamp.com>
pburgisser
force-pushed
the
update_applicationset_to_041
branch
from
161751b to
28aaf86
Compare
pburgisser
changed the title
mbevc1
reviewed
Apr 19, 2022
Signed-off-by: Philippe <philippe.burgisser@camptocamp.com>
mkilchhofer
approved these changes
Apr 22, 2022
There was a problem hiding this comment.
Its a bit in conflict with #1219. Maybe after we merge this change here, we deprecated the charts directly and only maintain it in argo-cd chart directly
|
Indeed, I realized that when I tested it in production with an old version of the Argo-cd helm chart :) |
Signed-off-by: Marco Kilchhofer <mkilchhofer@users.noreply.github.com>
mkilchhofer
reviewed
Apr 22, 2022
| @@ -33,6 +33,7 @@ spec: | |||
| securityContext: | |||
| {{- toYaml .Values.securityContext | nindent 12 }} | |||
| command: | |||
| - entrypoint.sh | |||
There was a problem hiding this comment.
Synced this change also from the upstream manifests
6 tasks
terrych0u
pushed a commit
to terrych0u/argo-helm
that referenced
this pull request
Aug 4, 2022
* feat: update appVersion to 0.4.1 Signed-off-by: Philippe <philippe.burgisser@camptocamp.com> * Update changelog Signed-off-by: Philippe <philippe.burgisser@camptocamp.com> * fix: Also sync entrypoint.sh change from upstream Signed-off-by: Marco Kilchhofer <mkilchhofer@users.noreply.github.com> Co-authored-by: Marco Kilchhofer <mkilchhofer@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note on DCO:
If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.
Checklist:
Changes are automatically published when merged to
master. They are not published on branches.