refactor(argo-cd)!: Remove Argo CD notification default notifier #1201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yixing Yan <yixingyan@gmail.com>
Signed-off-by: Yixing Yan <yixingyan@gmail.com>
yanyixing
requested review from
davidkarlsen,
yann-soubeyrand and
mbevc1
as code owners
mkilchhofer
reviewed
Mar 29, 2022
| @@ -2425,7 +2425,33 @@ notifications: | |||
| # {{if eq .serviceType "slack"}}:white_check_mark:{{end}} Application {{.app.metadata.name}} has been successfully synced at {{.app.status.operationState.finishedAt}}. | |||
| # Sync operation details are available at: {{.context.argocdUrl}}/applications/{{.app.metadata.name}}?operation=true . | |||
| # slack: | |||
| # attachments: "[{\n \"title\": \"{{ .app.metadata.name}}\",\n \"title_link\":\"{{.context.argocdUrl}}/applications/{{.app.metadata.name}}\",\n \"color\": \"#18be52\",\n \"fields\": [\n {\n \"title\": \"Sync Status\",\n \"value\": \"{{.app.status.sync.status}}\",\n \"short\": true\n },\n {\n \"title\": \"Repository\",\n \"value\": \"{{.app.spec.source.repoURL}}\",\n \"short\": true\n }\n {{range $index, $c := .app.status.conditions}}\n {{if not $index}},{{end}}\n {{if $index}},{{end}}\n {\n \"title\": \"{{$c.type}}\",\n \"value\": \"{{$c.message}}\",\n \"short\": true\n }\n {{end}}\n ]\n}] " | |||
There was a problem hiding this comment.
Cool, i like the reformatting!
mbevc1
approved these changes
Mar 29, 2022
Signed-off-by: Yixing Yan <yixingyan@gmail.com>
mkilchhofer
reviewed
Mar 29, 2022
Signed-off-by: Yixing Yan <yixingyan@gmail.com>
mkilchhofer
reviewed
Mar 29, 2022
charts/argo-cd/README.md
Outdated
| @@ -82,6 +82,9 @@ Changes in the `CustomResourceDefinition` resources shall be fixed easily by cop | |||
|
|
|||
| ## Upgrading | |||
|
|
|||
| ### 4.3.* | |||
|
|
|||
| With this minor version, the notification notifier's `service.slack` is no longer configured by default. | |||
There was a problem hiding this comment.
Please add a newline between your text and the next heading to fulfill markdown lint. Also please add it to README.md.gotmpl
mkilchhofer
changed the title
mkilchhofer
changed the title
mkilchhofer
changed the title
Signed-off-by: Yixing Yan <yixingyan@gmail.com>
6 tasks
terrych0u
pushed a commit
to terrych0u/argo-helm
that referenced
this pull request
Aug 4, 2022
…oproj#1201) * remove argocd notification default notifier Signed-off-by: Yixing Yan <yixingyan@gmail.com> * format notification template comment Signed-off-by: Yixing Yan <yixingyan@gmail.com> * Update the argo-cd chart to version 4.3.0 Signed-off-by: Yixing Yan <yixingyan@gmail.com> * update changelog Signed-off-by: Yixing Yan <yixingyan@gmail.com> * update readme Signed-off-by: Yixing Yan <yixingyan@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note on DCO:
If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.
Checklist:
Changes are automatically published when merged to
master. They are not published on branches.