fix(argo-cd): Correct ApplicationSet controller port #1200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
visheyra
requested review from
davidkarlsen,
yann-soubeyrand and
mbevc1
as code owners
mkilchhofer
changed the title
mkilchhofer
requested changes
Mar 28, 2022
There was a problem hiding this comment.
Hi @visheyra, thanks for your contribution.
These tasks still are open:
- Adapt Chart.yaml: bump version, and write a changelog line
- Sign-off your commit (git commit -s --amend)
For the change itself, i'd suggest to omit the containerPort from values and "hardcode" it as introduced here: e7a2746
It seems that @mikeeq missed that while he implemented the 2.3 changes
visheyra
force-pushed
the
default-containerport-argocd-applicationset-controller
branch
2 times, most recently
from
4f9ff2f to
85fbdb8
Compare
|
@mkilchhofer Okay, I think indeed hardcoding it is better ^^. I pushed/force I think this cover all your points now ? |
visheyra
force-pushed
the
default-containerport-argocd-applicationset-controller
branch
2 times, most recently
from
3eacfbc to
6a641ec
Compare
Signed-off-by: amaury ravanel <amaury.ravanel@gmail.com>
visheyra
force-pushed
the
default-containerport-argocd-applicationset-controller
branch
from
6a641ec to
98f2075
Compare
mkilchhofer
reviewed
Mar 28, 2022
mkilchhofer
reviewed
Mar 28, 2022
Signed-off-by: Marco Kilchhofer <mkilchhofer@users.noreply.github.com>
mkilchhofer
changed the title
mkilchhofer
changed the title
terrych0u
pushed a commit
to terrych0u/argo-helm
that referenced
this pull request
Aug 4, 2022
* Add default value for the applicationSet controller container port Signed-off-by: amaury ravanel <amaury.ravanel@gmail.com> * Apply suggestions from code review Signed-off-by: Marco Kilchhofer <mkilchhofer@users.noreply.github.com> Co-authored-by: Marco Kilchhofer <mkilchhofer@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR propose a fix for the #1199.
Note on DCO:
If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.
Checklist:
Changes are automatically published when merged to
master. They are not published on branches.