feat(argo-cd ingress): support google managed certificates for gce ingress #1088
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robertlindner
requested review from
davidkarlsen,
mbevc1 and
yann-soubeyrand
as code owners
robertlindner
changed the title
Signed-off-by: Robert Lindner <robert.lindner@delivion.de>
I.e. for adding a http to https redirect on the load balancer. Signed-off-by: Robert Lindner <robert.lindner@delivion.de>
robertlindner
force-pushed
the
feature/Support_Google_ManagedCertificate
branch
from
08be853 to
9ac29ff
Compare
Signed-off-by: Marco Kilchhofer <mkilchhofer@users.noreply.github.com>
mkilchhofer
approved these changes
Jan 15, 2022
6 tasks
terrych0u
pushed a commit
to terrych0u/argo-helm
that referenced
this pull request
Aug 4, 2022
…gress (argoproj#1088) * Add support for Google ManagedCertificates Signed-off-by: Robert Lindner <robert.lindner@delivion.de> * Add support for Google FrontendConfigs I.e. for adding a http to https redirect on the load balancer. Signed-off-by: Robert Lindner <robert.lindner@delivion.de> * Apply changes from code review Signed-off-by: Marco Kilchhofer <mkilchhofer@users.noreply.github.com> Co-authored-by: Marco Kilchhofer <mkilchhofer@users.noreply.github.com>
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
In our organisation, we would like to use Google ManagedCertificates with GCE Ingress for exposing the ArgoCD web interface for our Developers.
Since the BackendConfig is already supported, I thought the other GKE Custom Resources might be useful for others who want to use GCE ingress, too.
I also added the FrontendConfig resource for setting features like SSL Policies and HTTP to HTTPS redirects on the loadbalancer.
Best regards,
Robert
Note on DCO:
If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.
Checklist:
Changes are automatically published when merged to
master. They are not published on branches.